Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s user guide to use deployments #474

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

edrevo
Copy link
Contributor

@edrevo edrevo commented Jun 1, 2021

Which issue does this PR close?

Closes #473.

What changes are included in this PR?

  • Rename port to bind-port since the configure_me create was trying to parse an env var that was being autopopulated by Kubernetes
  • Change the user guide for k8s

@edrevo edrevo changed the title K8s deployments Update k8s user guide to use deployments Jun 1, 2021
@edrevo
Copy link
Contributor Author

edrevo commented Jun 1, 2021

cc @andygrove

@codecov-commenter
Copy link

Codecov Report

Merging #474 (56aeaea) into master (1601112) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #474   +/-   ##
=======================================
  Coverage   75.84%   75.84%           
=======================================
  Files         153      153           
  Lines       25872    25872           
=======================================
  Hits        19622    19622           
  Misses       6250     6250           
Impacted Files Coverage Δ
ballista/rust/executor/src/main.rs 0.00% <0.00%> (ø)
ballista/rust/scheduler/src/main.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1601112...56aeaea. Read the comment docs.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @edrevo

@andygrove andygrove merged commit 01b57f7 into apache:master Jun 2, 2021
@edrevo edrevo deleted the k8s-deployments branch June 11, 2021 09:35
@houqp houqp added ballista documentation Improvements or additions to documentation labels Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ballista] Use deployments in k8s user guide
4 participants