Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the config datafusion.execution.coalesce_target_batch_size and use datafusion.execution.batch_size instead #4757

Merged
merged 5 commits into from
Dec 30, 2022

Conversation

yahoNanJing
Copy link
Contributor

@yahoNanJing yahoNanJing commented Dec 28, 2022

Which issue does this PR close?

Closes #4756.

Rationale for this change

As #4756 mentioned, there's already a config of datafusion.execution.batch_size to indicate the row number of a batch for processing. I don't think it's necessary to make a different batch size for the CoalesceBatches rule.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Dec 28, 2022
@yahoNanJing
Copy link
Contributor Author

Hi @alamb, @andygrove, could you help review this PR?

… use datafusion.execution.batch_size instead
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change makes a lot of sense. Thank you @yahoNanJing

Maybe @Dandandan remembers why there were two different batch sizes

.try_into()
.unwrap(),
)));
if config.coalesce_batches() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That reads much more nicely 👍

@alamb
Copy link
Contributor

alamb commented Dec 29, 2022

I plan to merge this later today unless there are any more comments.

@yahoNanJing
Copy link
Contributor Author

Since there's no opposite comments, I will merge this PR.

@yahoNanJing yahoNanJing merged commit f7477dc into apache:master Dec 30, 2022
@ursabot
Copy link

ursabot commented Dec 30, 2022

Benchmark runs are scheduled for baseline = ac876db and contender = f7477dc. f7477dc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the config datafusion.execution.coalesce_target_batch_size
4 participants