Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a constructor for the ConfigOptions with a string hash map #4758

Closed
wants to merge 4 commits into from

Conversation

yahoNanJing
Copy link
Contributor

@yahoNanJing yahoNanJing commented Dec 28, 2022

Which issue does this PR close?

Closes #4752, #3500.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Dec 28, 2022
@yahoNanJing yahoNanJing marked this pull request as draft December 28, 2022 09:03
@alamb
Copy link
Contributor

alamb commented Dec 29, 2022

This is so exciting!

@tustvold
Copy link
Contributor

FYI the config options rework in #4771 supports this out of the box, PTAL 😄

@alamb
Copy link
Contributor

alamb commented Apr 11, 2023

I think this PR may no longer be relevant and has accumulated many conflicts

@tustvold tustvold closed this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a constructor for the ConfigOptions with HashMap<String, String>
4 participants