Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ConfigOptions to core #4803

Merged
merged 5 commits into from
Jan 4, 2023
Merged

Move ConfigOptions to core #4803

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f852074
Move ConfigOptions to core
tustvold Jan 3, 2023
d6c4897
Fix defaults
tustvold Jan 3, 2023
8269515
Toml format
tustvold Jan 3, 2023
4d42ac8
Merge remote-tracking branch 'upstream/master' into move-config-to-co…
tustvold Jan 4, 2023
1221469
Merge remote-tracking branch 'upstream/master' into move-config-to-co…
tustvold Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion datafusion/optimizer/src/optimizer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,12 @@ pub struct OptimizerContext {
impl OptimizerContext {
/// Create optimizer config
pub fn new() -> Self {
let mut options = ConfigOptions::default();
options.optimizer.filter_null_join_keys = true;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double-checked this wasn't introduced by the recent config rework, and confirmed that it has always been the case that OptimizerContext defaults this to true, but ConfigOptions defaults it to false.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intention was always to have this default to false so this looks like a bug

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OptimizerContext is now only used within tests, and so I am going to leave this for now. If you feel strongly I can file a follow up PR to change this, but it creates a non-trivial amount of test-churn


Self {
query_execution_start_time: Utc::now(),
options: Default::default(),
options,
}
}

Expand Down