Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: reduce indent level in page filter pruning code #5105

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 29, 2023

Which issue does this PR close?

Part of #5104

Rationale for this change

I am working to fix the page pruning logic to handle schemas that are not the same across files. I find the nesting level of the page pruning code hard to work and I want to minimize the diff of the PR that will make actual logic changes to make it easier to review.

What changes are included in this PR?

  1. Reduces the nesting level.

No functional changes are intended

Are these changes tested?

Covered by existing tests

Are there any user-facing changes?

No

@github-actions github-actions bot added the core Core DataFusion crate label Jan 29, 2023
Copy link
Contributor Author

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing with whitespace blind diff I think shows more easily what is changed https://github.com/apache/arrow-datafusion/pull/5105/files?w=1

@alamb alamb force-pushed the alamb/refactor_page_index_pruning branch from 9c3f400 to cd8a184 Compare January 29, 2023 12:28
@alamb alamb marked this pull request as ready for review January 29, 2023 13:49
@alamb alamb requested a review from Ted-Jiang January 29, 2023 13:50
@alamb
Copy link
Contributor Author

alamb commented Feb 1, 2023

@Ted-Jiang or @tustvold or @thinkharderdev I wonder if you might have time over the next few days to review this (mechanical) PR (in support of trying to get page index enabled by default)?

@alamb alamb merged commit 8bae10b into apache:master Feb 1, 2023
@alamb alamb deleted the alamb/refactor_page_index_pruning branch February 1, 2023 17:35
@ursabot
Copy link

ursabot commented Feb 1, 2023

Benchmark runs are scheduled for baseline = f8607c2 and contender = 8bae10b. 8bae10b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants