Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 517 - move window_frames module to logical_plan #518

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Jun 6, 2021

Which issue does this PR close?

Based on #506
Closes #517.

Rationale for this change

What changes are included in this PR?

move window_frames module to logical_plan

Are there any user-facing changes?

@jimexist jimexist changed the title Fix 517 Fix 517 - move window_frames module to logical_plan Jun 6, 2021
@jimexist jimexist force-pushed the fix-517 branch 2 times, most recently from bb08f61 to 01d08a7 Compare June 7, 2021 03:20
@codecov-commenter
Copy link

Codecov Report

Merging #518 (01d08a7) into master (b84789a) will decrease coverage by 0.01%.
The diff coverage is 70.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
- Coverage   76.09%   76.07%   -0.02%     
==========================================
  Files         155      156       +1     
  Lines       26575    26750     +175     
==========================================
+ Hits        20221    20351     +130     
- Misses       6354     6399      +45     
Impacted Files Coverage Δ
...sta/rust/core/src/serde/logical_plan/from_proto.rs 35.41% <0.00%> (-0.51%) ⬇️
...lista/rust/core/src/serde/logical_plan/to_proto.rs 61.64% <0.00%> (-0.77%) ⬇️
...ta/rust/core/src/serde/physical_plan/from_proto.rs 38.51% <0.00%> (-0.14%) ⬇️
datafusion-cli/src/lib.rs 0.00% <0.00%> (ø)
datafusion-cli/src/main.rs 0.00% <0.00%> (ø)
datafusion/src/optimizer/utils.rs 48.05% <0.00%> (-0.18%) ⬇️
datafusion/src/physical_plan/planner.rs 80.19% <ø> (ø)
datafusion/src/sql/utils.rs 66.54% <50.00%> (-0.25%) ⬇️
datafusion/src/logical_plan/expr.rs 84.56% <81.81%> (-0.05%) ⬇️
datafusion/src/logical_plan/window_frames.rs 86.60% <86.60%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee2b9ef...01d08a7. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @houqp -- thanks @jimexist 👍

@alamb alamb merged commit 63accf8 into apache:master Jun 7, 2021
@jimexist jimexist deleted the fix-517 branch June 7, 2021 15:06
@houqp houqp added the datafusion Changes in the datafusion crate label Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move window frame module to be in logical_plan
4 participants