Disallow SORT BY in SQL #5249
Disallow SORT BY in SQL #5249
Conversation
| @@ -59,6 +59,9 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { | |||
| if select.top.is_some() { | |||
| return Err(DataFusionError::NotImplemented("TOP".to_string())); | |||
| } | |||
| if !select.sort_by.is_empty() { | |||
There was a problem hiding this comment.
👍
It would be nice to add a .slt test for this case, but I also think it is ok not to
|
Here is a proposed test: #5254 |
|
Benchmark runs are scheduled for baseline = 8719041 and contender = ec9119d. ec9119d is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #5247
Rationale for this change
What changes are included in this PR?
Are these changes tested?
No tests added. Adding tests for invalid SQL might not be desirable (considering potential surface area of invalid SQL)
Are there any user-facing changes?