Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "field not found" error messages #625

Merged
merged 1 commit into from
Jun 27, 2021

Conversation

andygrove
Copy link
Member

Which issue does this PR close?

Closes #624 .

Rationale for this change

Better UX.

What changes are included in this PR?

"Field 'X' not found" error messages now include list of valid fields.

Are there any user-facing changes?

Yes, better error messages.

@andygrove andygrove self-assigned this Jun 26, 2021
@github-actions github-actions bot added the datafusion Changes in the datafusion crate label Jun 26, 2021
Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 at some point we might want to limit the nr of records shown by default (for very wide tables)

@alamb
Copy link
Contributor

alamb commented Jun 27, 2021

This is a nice improvement - thanks @andygrove

@alamb alamb merged commit f995de5 into apache:master Jun 27, 2021
@houqp houqp added the enhancement New feature or request label Jul 31, 2021
@andygrove andygrove deleted the improve-field-not-found-errors branch February 6, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve "field not found" error messages
4 participants