Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support type cast in SchemaAdapter #6404

Merged
merged 4 commits into from
May 23, 2023
Merged

feat: support type cast in SchemaAdapter #6404

merged 4 commits into from
May 23, 2023

Conversation

e1ijah1
Copy link
Contributor

@e1ijah1 e1ijah1 commented May 22, 2023

Which issue does this PR close?

Closes #6381

Rationale for this change

What changes are included in this PR?

introduces a map_schema method that maps the file schema to the table schema, and a SchemaMapping structure to hold the mapping and necessary type conversions.

Are these changes tested?

Yes

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label May 22, 2023
@alamb alamb requested a review from tustvold May 22, 2023 13:47
tustvold
tustvold approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice, thank you. Left some minor comments, but this is also good to go as is

datafusion/core/src/physical_plan/file_format/mod.rs Outdated Show resolved Hide resolved
datafusion/core/src/physical_plan/file_format/mod.rs Outdated Show resolved Hide resolved
datafusion/core/src/physical_plan/file_format/mod.rs Outdated Show resolved Hide resolved
datafusion/core/src/physical_plan/file_format/mod.rs Outdated Show resolved Hide resolved
datafusion/core/src/physical_plan/file_format/mod.rs Outdated Show resolved Hide resolved
@e1ijah1
Copy link
Contributor Author

e1ijah1 commented May 23, 2023

This is really nice, thank you. Left some minor comments, but this is also good to go as is

Thank you for taking the time to review my PR 🙏. I have updated the code. Please take another look.

@e1ijah1 e1ijah1 requested a review from tustvold May 23, 2023 07:53
tustvold
tustvold approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@tustvold tustvold merged commit 32d49fb into apache:main May 23, 2023
@tustvold tustvold mentioned this pull request May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Type Coercion in SchemaAdapter
2 participants
@e1ijah1 @tustvold