Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve contradictory requirements by conversion of ordering sensitive aggregators #6482

Merged
merged 98 commits into from
Jun 3, 2023
Merged

Resolve contradictory requirements by conversion of ordering sensitive aggregators #6482

merged 98 commits into from
Jun 3, 2023

Commits on May 3, 2023

  1. Naive test pass

    i
    mustafasrepo committed May 3, 2023
    Configuration menu
    Copy the full SHA
    7411d6b View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Configuration menu
    Copy the full SHA
    87c397d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ebd0e5f View commit details
    Browse the repository at this point in the history
  3. update requirement

    mustafasrepo committed May 4, 2023
    Configuration menu
    Copy the full SHA
    ecc5b0d View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. update tests

    mustafasrepo committed May 5, 2023
    Configuration menu
    Copy the full SHA
    7093fa7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e377ea9 View commit details
    Browse the repository at this point in the history
  3. Resolve linter errors

    mustafasrepo committed May 5, 2023
    Configuration menu
    Copy the full SHA
    e0ce989 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'main' into feature/ordering_sensitive_aggregation

    # Conflicts:
    #	datafusion/core/tests/sqllogictests/test_files/aggregate.slt
    mustafasrepo committed May 5, 2023
    Configuration menu
    Copy the full SHA
    e3edf7c View commit details
    Browse the repository at this point in the history
  5. update comments

    mustafasrepo committed May 5, 2023
    Configuration menu
    Copy the full SHA
    550416e View commit details
    Browse the repository at this point in the history
  6. minor changes

    mustafasrepo committed May 5, 2023
    Configuration menu
    Copy the full SHA
    d72cc8f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    713b56b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3dcf079 View commit details
    Browse the repository at this point in the history
  9. update proto files

    mustafasrepo committed May 5, 2023
    Configuration menu
    Copy the full SHA
    a817887 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. Simplifications

    ozankabak committed May 6, 2023
    Configuration menu
    Copy the full SHA
    740a605 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. Configuration menu
    Copy the full SHA
    8209c46 View commit details
    Browse the repository at this point in the history
  2. Update todos

    mustafasrepo committed May 8, 2023
    Configuration menu
    Copy the full SHA
    d93b187 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Convert API to vector

    mustafasrepo committed May 9, 2023
    Configuration menu
    Copy the full SHA
    5bb8dde View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    72985f8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4ae5c25 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6fd96da View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Merge branch 'main' into feature/ordering_sensitive_aggregation

    # Conflicts:
    #	datafusion/core/src/physical_plan/planner.rs
    #	datafusion/core/tests/sqllogictests/test_files/aggregate.slt
    #	datafusion/expr/src/expr.rs
    #	datafusion/expr/src/tree_node/expr.rs
    #	datafusion/expr/src/udaf.rs
    #	datafusion/optimizer/src/analyzer/type_coercion.rs
    #	datafusion/optimizer/src/common_subexpr_eliminate.rs
    #	datafusion/proto/src/logical_plan/from_proto.rs
    #	datafusion/proto/src/logical_plan/mod.rs
    #	datafusion/proto/src/logical_plan/to_proto.rs
    #	datafusion/sql/src/expr/function.rs
    #	datafusion/sql/src/utils.rs
    mustafasrepo committed May 10, 2023
    Configuration menu
    Copy the full SHA
    0a52150 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    61cc109 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    682b1f4 View commit details
    Browse the repository at this point in the history
  4. Update cargo.lock

    mustafasrepo committed May 10, 2023
    Configuration menu
    Copy the full SHA
    670a327 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4c27b85 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e9535bd View commit details
    Browse the repository at this point in the history
  7. Update cargo lock

    mustafasrepo committed May 10, 2023
    Configuration menu
    Copy the full SHA
    2143b72 View commit details
    Browse the repository at this point in the history
  8. Merge branch 'feature/ordering_sensitive_aggregation' into feature/fi…

    …rst_last_aggregate
    
    # Conflicts:
    #	datafusion/expr/Cargo.toml
    mustafasrepo committed May 10, 2023
    Configuration menu
    Copy the full SHA
    10e7811 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Minor code simplifications

    ozankabak committed May 11, 2023
    Configuration menu
    Copy the full SHA
    c59ce9b View commit details
    Browse the repository at this point in the history
  2. Update comment

    mustafasrepo committed May 11, 2023
    Configuration menu
    Copy the full SHA
    90aa195 View commit details
    Browse the repository at this point in the history
  3. Update documents

    mustafasrepo committed May 11, 2023
    Configuration menu
    Copy the full SHA
    9abfe65 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Merge branch 'main' into feature/first_last_aggregate

    # Conflicts:
    #	datafusion/core/tests/sql/group_by.rs
    mustafasrepo committed May 12, 2023
    Configuration menu
    Copy the full SHA
    0527c20 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8456a8d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a4eced0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    344e184 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'feature/ordering_sensitive_aggregation' into feature/fi…

    …rst_last_aggregate
    
    # Conflicts:
    #	datafusion/expr/src/tree_node/expr.rs
    mustafasrepo committed May 12, 2023
    Configuration menu
    Copy the full SHA
    2d1482d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9d01d4d View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Merge branch 'main' into feature/first_last_aggregate

    # Conflicts:
    #	datafusion/core/src/physical_plan/aggregates/mod.rs
    #	datafusion/core/tests/sqllogictests/test_files/groupby.slt
    #	datafusion/proto/proto/datafusion.proto
    #	datafusion/proto/src/generated/pbjson.rs
    #	datafusion/proto/src/generated/prost.rs
    #	datafusion/sql/src/expr/mod.rs
    mustafasrepo committed May 16, 2023
    Configuration menu
    Copy the full SHA
    9be10fb View commit details
    Browse the repository at this point in the history
  2. Update documentation

    mustafasrepo committed May 16, 2023
    Configuration menu
    Copy the full SHA
    8fc5b82 View commit details
    Browse the repository at this point in the history
  3. Update subproject

    mustafasrepo committed May 16, 2023
    Configuration menu
    Copy the full SHA
    2ac73d6 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. initial commit

    mustafasrepo committed May 18, 2023
    Configuration menu
    Copy the full SHA
    dbe0826 View commit details
    Browse the repository at this point in the history
  2. Add test code

    mustafasrepo committed May 18, 2023
    Configuration menu
    Copy the full SHA
    118fa92 View commit details
    Browse the repository at this point in the history
  3. initial version

    mustafasrepo committed May 18, 2023
    Configuration menu
    Copy the full SHA
    228d973 View commit details
    Browse the repository at this point in the history
  4. simplify prints

    mustafasrepo committed May 18, 2023
    Configuration menu
    Copy the full SHA
    c9cca16 View commit details
    Browse the repository at this point in the history
  5. minor changes

    mustafasrepo committed May 18, 2023
    Configuration menu
    Copy the full SHA
    8a87fdb View commit details
    Browse the repository at this point in the history
  6. sqllogictests pass

    mustafasrepo committed May 18, 2023
    Configuration menu
    Copy the full SHA
    1db5683 View commit details
    Browse the repository at this point in the history
  7. All tests pass

    mustafasrepo committed May 18, 2023
    Configuration menu
    Copy the full SHA
    2b2ae1d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2804350 View commit details
    Browse the repository at this point in the history
  9. Minor changes

    mustafasrepo committed May 18, 2023
    Configuration menu
    Copy the full SHA
    e5a2776 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Merge branch 'main' into feature/first_last_aggregate2

    # Conflicts:
    #	datafusion-cli/Cargo.lock
    #	datafusion/expr/Cargo.toml
    mustafasrepo committed May 22, 2023
    Configuration menu
    Copy the full SHA
    0889165 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    af4d209 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eacfaff View commit details
    Browse the repository at this point in the history
  4. initial commit

    mustafasrepo committed May 22, 2023
    Configuration menu
    Copy the full SHA
    d941da4 View commit details
    Browse the repository at this point in the history
  5. Add new tests

    mustafasrepo committed May 22, 2023
    Configuration menu
    Copy the full SHA
    956f76b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    aeb5d0f View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. simplifications

    mustafasrepo committed May 23, 2023
    Configuration menu
    Copy the full SHA
    4ce1038 View commit details
    Browse the repository at this point in the history
  2. simplifications

    mustafasrepo committed May 23, 2023
    Configuration menu
    Copy the full SHA
    409ad65 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e54b9f2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    148dec2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    19460a1 View commit details
    Browse the repository at this point in the history
  6. Fix cargo lock file

    mustafasrepo committed May 23, 2023
    Configuration menu
    Copy the full SHA
    1bdda38 View commit details
    Browse the repository at this point in the history
  7. Merge branch 'feature/first_last_aggregate2' into feature/first_last_…

    …conversion
    
    # Please enter a commit message to explain why this merge is necessary,
    # especially if it merges an updated upstream into a topic branch.
    #
    # Lines starting with '#' will be ignored, and an empty message aborts
    # the commit.
    mustafasrepo committed May 23, 2023
    Configuration menu
    Copy the full SHA
    05f3af2 View commit details
    Browse the repository at this point in the history
  8. Merge branch 'main' into feature/first_last_aggregate2

    # Conflicts:
    #	datafusion-cli/Cargo.lock
    #	datafusion/common/Cargo.toml
    #	datafusion/core/Cargo.toml
    #	datafusion/expr/Cargo.toml
    #	datafusion/sql/Cargo.toml
    mustafasrepo committed May 23, 2023
    Configuration menu
    Copy the full SHA
    fab0dcd View commit details
    Browse the repository at this point in the history
  9. Merge branch 'feature/first_last_aggregate2' into feature/first_last_…

    …conversion
    
    # Please enter a commit message to explain why this merge is necessary,
    # especially if it merges an updated upstream into a topic branch.
    #
    # Lines starting with '#' will be ignored, and an empty message aborts
    # the commit.
    mustafasrepo committed May 23, 2023
    Configuration menu
    Copy the full SHA
    17338e5 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Configuration menu
    Copy the full SHA
    61b2b13 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ba9ffeb View commit details
    Browse the repository at this point in the history
  3. Add new tests

    mustafasrepo committed May 24, 2023
    Configuration menu
    Copy the full SHA
    35cf310 View commit details
    Browse the repository at this point in the history
  4. simplifications

    mustafasrepo committed May 24, 2023
    Configuration menu
    Copy the full SHA
    16ee108 View commit details
    Browse the repository at this point in the history
  5. Update comment

    mustafasrepo committed May 24, 2023
    Configuration menu
    Copy the full SHA
    94fe486 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    13ee806 View commit details
    Browse the repository at this point in the history
  7. Merge branch 'feature/first_last_aggregate2' into feature/first_last_…

    …conversion
    
    # Conflicts:
    #	datafusion/core/src/physical_plan/aggregates/mod.rs
    mustafasrepo committed May 24, 2023
    Configuration menu
    Copy the full SHA
    8f91e66 View commit details
    Browse the repository at this point in the history
  8. minor change

    berkaysynnada committed May 24, 2023
    Configuration menu
    Copy the full SHA
    1cd494f View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Comment improvements

    ozankabak committed May 25, 2023
    Configuration menu
    Copy the full SHA
    f2a0a68 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c4a47e2 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Merge branch 'main' into feature/first_last_aggregate2

    # Please enter a commit message to explain why this merge is necessary,
    # especially if it merges an updated upstream into a topic branch.
    #
    # Lines starting with '#' will be ignored, and an empty message aborts
    # the commit.
    mustafasrepo committed May 26, 2023
    Configuration menu
    Copy the full SHA
    c20ca75 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'feature/first_last_aggregate2' into feature/first_last_…

    …conversion
    
    # Conflicts:
    #	datafusion/core/src/physical_plan/aggregates/mod.rs
    #	datafusion/core/tests/sqllogictests/test_files/groupby.slt
    mustafasrepo committed May 26, 2023
    Configuration menu
    Copy the full SHA
    6544a6b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c61daca View commit details
    Browse the repository at this point in the history
  4. Remove clone

    berkaysynnada committed May 26, 2023
    Configuration menu
    Copy the full SHA
    5aee4de View commit details
    Browse the repository at this point in the history
  5. Simplifications

    mustafasrepo committed May 26, 2023
    Configuration menu
    Copy the full SHA
    e591ff8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fcb8103 View commit details
    Browse the repository at this point in the history
  7. Merge branch 'main' into feature/first_last_aggregate2

    # Please enter a commit message to explain why this merge is necessary,
    # especially if it merges an updated upstream into a topic branch.
    #
    # Lines starting with '#' will be ignored, and an empty message aborts
    # the commit.
    mustafasrepo committed May 26, 2023
    Configuration menu
    Copy the full SHA
    d140e97 View commit details
    Browse the repository at this point in the history
  8. Merge branch 'feature/first_last_aggregate2' into feature/first_last_…

    …conversion
    
    # Please enter a commit message to explain why this merge is necessary,
    # especially if it merges an updated upstream into a topic branch.
    #
    # Lines starting with '#' will be ignored, and an empty message aborts
    # the commit.
    mustafasrepo committed May 26, 2023
    Configuration menu
    Copy the full SHA
    8275962 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2023

  1. Merge branch 'main' into feature/first_last_conversion

    # Conflicts:
    #	datafusion/core/src/physical_plan/aggregates/mod.rs
    #	datafusion/core/tests/sqllogictests/test_files/groupby.slt
    #	datafusion/core/tests/sqllogictests/test_files/window.slt
    #	datafusion/expr/src/aggregate_function.rs
    #	datafusion/expr/src/window_function.rs
    #	datafusion/physical-expr/src/lib.rs
    mustafasrepo committed May 27, 2023
    Configuration menu
    Copy the full SHA
    dfec660 View commit details
    Browse the repository at this point in the history
  2. Improve comments

    ozankabak committed May 27, 2023
    Configuration menu
    Copy the full SHA
    72eddac View commit details
    Browse the repository at this point in the history

Commits on May 29, 2023

  1. Configuration menu
    Copy the full SHA
    4d6b084 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f3db767 View commit details
    Browse the repository at this point in the history
  3. bug fix:

    mustafasrepo committed May 29, 2023
    Configuration menu
    Copy the full SHA
    a3434f3 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Configuration menu
    Copy the full SHA
    d47530d View commit details
    Browse the repository at this point in the history
  2. Update test

    mustafasrepo committed May 30, 2023
    Configuration menu
    Copy the full SHA
    2892f85 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. Merge branch 'main' into feature/first_last_conversion

    # Conflicts:
    #	datafusion/physical-expr/src/lib.rs
    #	datafusion/physical-expr/src/sort_expr.rs
    mustafasrepo committed May 31, 2023
    Configuration menu
    Copy the full SHA
    926a3e3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7a5e17b View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Update comments

    mustafasrepo committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    165a44f View commit details
    Browse the repository at this point in the history
  2. Change function place

    mustafasrepo committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    a29a12f View commit details
    Browse the repository at this point in the history
  3. Move get_finer to utls

    mustafasrepo committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    2581b29 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Configuration menu
    Copy the full SHA
    1cb0aaf View commit details
    Browse the repository at this point in the history
  2. Fix error message

    mustafasrepo committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    966341f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d696694 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'main' into feature/first_last_conversion

    # Please enter a commit message to explain why this merge is necessary,
    # especially if it merges an updated upstream into a topic branch.
    #
    # Lines starting with '#' will be ignored, and an empty message aborts
    # the commit.
    mustafasrepo committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    949e152 View commit details
    Browse the repository at this point in the history