Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support table columns alias #735

Merged
merged 9 commits into from
Jul 18, 2021
Merged

Conversation

Dandandan
Copy link
Contributor

@Dandandan Dandandan commented Jul 16, 2021

Which issue does this PR close?

Closes #739

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@Dandandan Dandandan changed the title WIP: Support table column alias WIP: Support table columns alias Jul 16, 2021
@github-actions github-actions bot added the datafusion Changes in the datafusion crate label Jul 16, 2021
@Dandandan Dandandan changed the title WIP: Support table columns alias Support table columns alias Jul 17, 2021
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks @Dandandan

fn table_with_column_alias() {
let sql = "SELECT a, b, c
FROM lineitem l (a, b, c)";
let expected = "Projection: #a, #b, #c\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Dandandan Dandandan merged commit 666360b into apache:master Jul 18, 2021
@alamb
Copy link
Contributor

alamb commented Jul 18, 2021

🎉

@houqp houqp added the enhancement New feature or request label Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support column names alias
3 participants