Minor: Add comment explaining why verify benchmark results uses release mode #7712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se mode While looking into #7709 I discovered why this test is run in release mode, and I wanted to leave a note for my future self
viirya
reviewed
Oct 1, 2023
| @@ -241,6 +241,7 @@ jobs: | |||
| - name: Verify that benchmark queries return expected results | |||
| run: | | |||
| export TPCH_DATA=`realpath datafusion/sqllogictest/test_files/tpch/data` | |||
| # use release build for plan verificaton because debug build causes stack overflow | |||
There was a problem hiding this comment.
Hmm, do you know what the cause of stack overflow there under debug build?
There was a problem hiding this comment.
From #7709 (comment) it appears that round_trip_logical_plan_q21 fails for some reason.
I did not debug it further.
viirya
approved these changes
Oct 1, 2023
|
Thank you @viirya |
Ted-Jiang
pushed a commit
to Ted-Jiang/arrow-datafusion
that referenced
this pull request
Oct 7, 2023
…se mode (apache#7712) While looking into apache#7709 I discovered why this test is run in release mode, and I wanted to leave a note for my future self
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #7709
Rationale for this change
While looking into #7709 I discovered why this test is run in release mode, and I wanted to leave a note for my future self
What changes are included in this PR?
Add a comment
Are these changes tested?
Are there any user-facing changes?