Fix column name for COUNT(*) set by AggregateStatistics #7757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue of column name COUNT(UInt8) appearing instead Resolves apache#104
github-actions
bot
added
core
|
The failure in in |
|
The failure in in cargo test doc seems to happen in CI itself
Indeed -- https://github.com/apache/arrow-datafusion/actions/runs/6434063712/job/17472738458?pr=7757 looks like some infrastructure error |
alamb
approved these changes
Oct 6, 2023
| @@ -93,7 +93,7 @@ query TT | |||
| EXPLAIN select count(*) from (values ('a', 1, 100), ('a', 2, 150)) as t (c1,c2,c3) | |||
| ---- | |||
| physical_plan | |||
| ProjectionExec: expr=[2 as COUNT(UInt8(1))] | |||
| ProjectionExec: expr=[2 as COUNT(*)] | |||
There was a problem hiding this comment.
I think this covers the output as well.
|
I restarted the doc test |
This might be the lowest ticket we have had closed in a while 🏆 |
Ted-Jiang
pushed a commit
to Ted-Jiang/arrow-datafusion
that referenced
this pull request
Oct 7, 2023
This fixes the issue of column name COUNT(UInt8) appearing instead Resolves #104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue of column name
COUNT(UInt8)appearing instead ofCOUNT(*)Which issue does this PR close?
Closes #104.
Rationale for this change
This should make produced column name consistent with the input SQL
What changes are included in this PR?
Are these changes tested?
Tested with
cargo testAre there any user-facing changes?
Changes column name for this particular case