Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate README.md #79

Merged
merged 2 commits into from
Apr 26, 2021
Merged

Deduplicate README.md #79

merged 2 commits into from
Apr 26, 2021

Conversation

msathis
Copy link
Contributor

@msathis msathis commented Apr 26, 2021

Which issue does this PR close?

Closes #71 .

Rationale for this change

Removing duplicated content

What changes are included in this PR?

Remove duplicated content & move Developers.md to root

Are there any user-facing changes?

N/A

@Dandandan
Copy link
Contributor

Thanks @msathis ! just an idea, maybe we can point the datafusion crate to the readme in the root too?

https://doc.rust-lang.org/cargo/reference/manifest.html#the-readme-field

@msathis
Copy link
Contributor Author

msathis commented Apr 26, 2021

Thanks @msathis ! just an idea, maybe we can point the datafusion crate to the readme in the root too?

Nice idea 💡 @Dandandan. Never knew this. Will do it 👌

@msathis msathis changed the title Deduplicate README.md [Ballista] Deduplicate README.md Apr 26, 2021
@msathis msathis changed the title [Ballista] Deduplicate README.md [Datafusion] Deduplicate README.md Apr 26, 2021
@msathis msathis marked this pull request as ready for review April 26, 2021 07:01
Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks good! 😎

@alamb alamb changed the title [Datafusion] Deduplicate README.md Deduplicate README.md Apr 26, 2021
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @msathis !

Comment on lines +144 to +148
- [x] Constant folding
- [x] Join Reordering
- [x] Limit Pushdown
- [x] Projection push down
- [x] Predicate push down
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these were meant to be sub bullets (they are features of the query optimizer) but we can fix that in a subsequent PR)

@alamb alamb merged commit e973e30 into apache:master Apr 26, 2021
@msathis msathis deleted the deduplicate-readme branch April 27, 2021 05:29
@houqp houqp added documentation Improvements or additions to documentation datafusion Changes in the datafusion crate labels Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deduplicate README.md files in root and datafusion directory
4 participants