-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support determining extensions from names like foo.parquet.snappy
as well as foo.parquet
#7972
Merged
+140
−0
Merged
feat: Support determining extensions from names like foo.parquet.snappy
as well as foo.parquet
#7972
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
d77794b
feat: read files based on the file extention
Weijun-H 97bad2f
fix: some the file extension might be started with . and some not
Weijun-H 6484840
fix: rename extention to extension
Weijun-H b53f4a4
chore: use exec_err
Weijun-H 47b5a9f
chore: rename extention to extension
Weijun-H a801398
chore: rename extention to extension
Weijun-H 9f68f35
chore: simplify the code
Weijun-H 36c7f54
fix: check table is empty
Weijun-H 4ff028b
ci: fix test
Weijun-H 3c29440
fix: add err info
Weijun-H f6c0568
refactor: extract the logic to infer_types
Weijun-H d250698
fix: add tests for different extensions
Weijun-H 7217be4
fix: ci clippy
Weijun-H c17158f
fix: add more tests
Weijun-H 5f751b7
fix: simplify the logic
Weijun-H 744006f
fix: ci
Weijun-H File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty confused about this implementation. If the goal is to detect files that don't end with the expected extension, can't we just do something like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right. I made this logic too complicated.