Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate ordering equivalence for expressions (rather than just columns) #8281

Merged
merged 7 commits into from
Nov 23, 2023
Merged

Calculate ordering equivalence for expressions (rather than just columns) #8281

merged 7 commits into from
Nov 23, 2023

Commits on Nov 17, 2023

  1. Complex exprs requirement support (#215) 

    * Discover ordering of complex expressions in group by and window partition by

* Remove unnecessary tests

* Update comments

* Minor changes

* Better projection support complex expression support

* Fix failing test

* Simplifications

* Simplifications

* Add is end flag

* Simplifications

* Simplifications

* Simplifications

* Minor changes

* Minor changes

* Minor changes

* All tests pass

* Change implementation of find_longest_permutation

* Minor changes

* Minor changes

* Remove projection section

* Remove projection implementation

* Fix linter errors

* Remove projection sections

* Minor changes

* Add docstring comments

* Add comments

* Minor changes

* Minor changes

* Add comments

* simplifications
    @mustafasrepo
    mustafasrepo authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    7a1e030 View commit details
    Browse the repository at this point in the history

  2. Minor changes

    @mustafasrepo
    mustafasrepo committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    b35d343 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Review Part 1

    @ozankabak
    ozankabak committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    bb77516 View commit details
    Browse the repository at this point in the history

  2. Add new tests

    @mustafasrepo
    mustafasrepo committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    b5f0ef8 View commit details
    Browse the repository at this point in the history

  3. Review Part 2

    @ozankabak
    ozankabak committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    8ee9f1e View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Address review feedback

    @ozankabak
    ozankabak committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    3319c8d View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Remove error message check in the test

    @mustafasrepo
    mustafasrepo committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    13dcd6c View commit details
    Browse the repository at this point in the history