Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR]: Move merge projections tests to under optimize projections #8352

Merged
merged 1 commit into from
Nov 29, 2023
Merged

[MINOR]: Move merge projections tests to under optimize projections #8352

merged 1 commit into from
Nov 29, 2023

Conversation

mustafasrepo
Copy link
Contributor

@mustafasrepo mustafasrepo commented Nov 29, 2023 •
edited
Loading

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

As suggested by @jonahgao in discussion. This PR moves tests under merge_projection.rs file to under optimize_projections.rs

Are these changes tested?

Are there any user-facing changes?

Existing tests

@github-actions github-actions bot added the optimizer Optimizer rules label Nov 29, 2023
alamb
alamb approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mustafasrepo

@alamb alamb merged commit 4c914ea into apache:main Nov 29, 2023
23 checks passed
@alamb alamb mentioned this pull request Nov 29, 2023
Closed
8 tasks
@matthewgapp matthewgapp mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
optimizer Optimizer rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mustafasrepo @alamb