Minor: Remove unnecessary name field in ScalarFunctionDefintion
#8365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to / follow on to #8258 from @2010YOUY01
Rationale for this change
While integrating #8258 into our downstream system, I found creating a
BuildInScalarFunction
to be quite awkward as it had a seemingly duplicated name field. I thought the name field was to handle aliases or something, but it turns out I could remove it easily.What changes are included in this PR?
Basically change the
ScalarFunctionDefinition::BuiltIn
to match the othersto
Are these changes tested?
Covered by existing tests
Are there any user-facing changes?
While this is technically an API change the API hasn't been released so it isn't an additional breaking API change