Preserve dict_id on Field during serde roundtrip
#8457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to apache/arrow-rs#1206 . I think if we go that route, then we still:
|
7 tasks
Dandandan
approved these changes
Dec 8, 2023
|
Thank you @avantgardnerio 🥳 |
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Dec 15, 2023
* Failing test * Passing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8461.
Rationale for this change
When round-tripping a Schema in our application, we noticed the
dict_idonFields appears to "get lost", which breaks what we are working on. This PR is an attempt to prove / fix the issue.What changes are included in this PR?
Serde the info.
Are these changes tested?
With a unit test.
Are there any user-facing changes?
Serde should work better.