Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Use faster check for column name in schema merge #8765

Merged

Conversation

matthewmturner
Copy link
Contributor

@matthewmturner matthewmturner commented Jan 5, 2024

Which issue does this PR close?

Part of #5309

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@matthewmturner
Copy link
Contributor Author

Benchmark impact from this change

image

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it -- thank you @matthewmturner

@alamb alamb changed the title Update checking columns in schema merge Minor: Use caster check for column name in schema merge Jan 5, 2024
@alamb alamb merged commit 6e75297 into apache:main Jan 5, 2024
23 checks passed
@alamb alamb changed the title Minor: Use caster check for column name in schema merge Minor: Use faster check for column name in schema merge Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants