-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port tests in timestamp.rs to sqllogictest. Part 1 #8818
Conversation
|
Dot't merge |
Hi @caicancai -- if there are tests that can't be ported to sqllogictest (for example, that now() doesn't change across session statements) can you please put a comment on them saying something like "can't write this in sqllogictest, so use a rust test" and just leave them in timestamp.rs? Thank you 🙏 |
@alamb Hello, I have two questions here.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think now
can still be ported, its not stable value, but we can do it quasi stable like
select now() = current_time
or
select now() > to_date('2023-01-01')
Thank you for your reply. I noticed that the original timestamp.slt already has some tests belonging to now. I am not sure whether to continue adding them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for double checking now()
is in timestamp.slt
, I also verified that and looks like test in slt for now is enough, and now I'm wondering if we still need timestamp.rs
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @caicancai -- this looks like a good improvement to me. Perhaps we can investigate @comphead 's question about needing timestamp.rs at all as part of a follow on PR
From a personal point of view, I agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @caicancai thanks.
I think it will be good to create a followup ticket to move remaining tests. I went trhough them real quick they looks migratable imho
Which issue does this PR close?
part of #8216
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?