Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive CTEs: Stage 1 - add config flag #8828

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

matthewgapp
Copy link
Contributor

@matthewgapp matthewgapp commented Jan 11, 2024

This PR is the first step in a series of PRs to fully implement recursive CTEs in DF. This PR adds a config flag that will be used to gate further implementation of recursive CTE logical and execution plans

Which issue does this PR close?

Working toward closing #462

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the sql SQL Planner label Jan 11, 2024
@alamb
Copy link
Contributor

alamb commented Jan 11, 2024

Thanks @matthewgapp -- what would you think about filing a ticket with the implementation plan described in #7581 (comment) (or maybe we can put it on #462 itself)?

@alamb
Copy link
Contributor

alamb commented Jan 12, 2024

I think some tests need updating to get the CI run clean here

@matthewgapp
Copy link
Contributor Author

matthewgapp commented Jan 12, 2024

I think some tests need updating to get the CI run clean here

Yeah, this is still a draft, so not quite ready for CI. I'm going to be readying these PRs this afternoon and will mark them Ready for review when done.

@matthewgapp
Copy link
Contributor Author

matthewgapp commented Jan 13, 2024

I think some tests need updating to get the CI run clean here

Yeah, this is still a draft, so not quite ready for CI. I'm going to be readying these PRs this afternoon and will mark them Ready for review when done.

Spent most of my time today digging into the repro and solution to the bug(s) we're seeing downstream. Hope to finish that and then clean up these PRs this weekend.

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Jan 13, 2024
@matthewgapp matthewgapp force-pushed the matt/feat/recursive-ctes/config-flag branch from 5c9fec5 to 91bc4a8 Compare January 14, 2024 00:05
@matthewgapp
Copy link
Contributor Author

I think some tests need updating to get the CI run clean here

Yeah, this is still a draft, so not quite ready for CI. I'm going to be readying these PRs this afternoon and will mark them Ready for review when done.

Spent most of my time today digging into the repro and solution to the bug(s) we're seeing downstream. Hope to finish that and then clean up these PRs this weekend.

Thinking that I'll have these three PRs ready for review sometime tomorrow afternoon.

@matthewgapp matthewgapp force-pushed the matt/feat/recursive-ctes/config-flag branch from fa99090 to 91bc4a8 Compare January 15, 2024 18:32
@matthewgapp matthewgapp marked this pull request as ready for review January 15, 2024 22:05
@matthewgapp
Copy link
Contributor Author

Thinking that I'll have these three PRs ready for review sometime tomorrow afternoon.

Think it's ready for review :)

testing Outdated Show resolved Hide resolved
update docs from script

update slt test for doc change
@matthewgapp matthewgapp force-pushed the matt/feat/recursive-ctes/config-flag branch from 91bc4a8 to 162e740 Compare January 16, 2024 17:31
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @matthewgapp

@alamb alamb merged commit 89d22b4 into apache:main Jan 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sql SQL Planner sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants