Port tests in group_by.rs to sqllogictest
#8834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
hiltontj
commented
Jan 11, 2024
Comment on lines
+4353
to
+4364
| # GROUP BY using LIMIT | ||
| query IP | ||
| SELECT c2, MAX(t1) | ||
| FROM timestamp_table | ||
| GROUP BY c2 | ||
| ORDER BY MAX(t1) DESC | ||
| LIMIT 4; | ||
| ---- | ||
| 9 2020-12-19T00:00:00 | ||
| 8 2020-12-18T00:00:00 | ||
| 7 2020-12-17T00:00:00 | ||
| 6 2020-12-16T00:00:00 |
There was a problem hiding this comment.
This, along with the following EXPLAIN query, is intended to cover the original group_by_limit test. In the original test, the table used was different in that the trace_id column was UTF8, vs. INT here. I am re-using the same table from the date_trunc test here for convenience, but I believe this still maintains the assertions being made.
7 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8202
Rationale for this change
See #6195
What changes are included in this PR?
datafusion/core/tests/sql/group_by.rstogroup_by.slt(formerlygroupby.slt)group_by_date_truncgroup_by_limitgroup_by_dictionarygroup_by.rsfileAre these changes tested?
Yes
Are there any user-facing changes?
No