Port tests in timestamp.rs to sqllogictest

[caicancai]

Which issue does this PR close?

Closes #8216

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

[caicancai]

I don’t know why my cli failed. What else needs to be modified?

[alamb]

I don’t know why my cli failed. What else needs to be modified?

It looks like there is some additional code that is no longer used that must be removed to satisfy clippy:

https://github.com/apache/arrow-datafusion/actions/runs/7517905372/job/20464643740?pr=8859

error: unused import: `chrono::Duration`
  --> datafusion/core/tests/sql/mod.rs:25:5
   |
25 | use chrono::Duration;
   |     ^^^^^^^^^^^^^^^^
   |
   = note: `-D unused-imports` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_imports)]`

error: function `make_timestamp_table` is never used
   --> datafusion/core/tests/sql/mod.rs:585:4
    |
585 | fn make_timestamp_table<A>() -> Result<Arc<MemTable>>
    |    ^^^^^^^^^^^^^^^^^^^^
    |
    = note: `-D dead-code` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(dead_code)]`

error: function `make_timestamp_tz_table` is never used
   --> datafusion/core/tests/sql/mod.rs:592:4
    |
592 | fn make_timestamp_tz_table<A>(tz: Option<Arc<str>>) -> Result<Arc<MemTable>>
    |    ^^^^^^^^^^^^^^^^^^^^^^^

error: function `make_timestamp_tz_sub_table` is never used
   --> datafusion/core/tests/sql/mod.rs:627:4
    |
627 | fn make_timestamp_tz_sub_table<A>(
    |    ^^^^^^^^^^^^^^^^^^^^^^^^^^^

[alamb]

I took the liberty of fixing the clippy error and merging this branch from main

[alamb]

Thanks again @caicancai

[caicancai]

I took the liberty of fixing the clippy error and merging this branch from main

Thank you for doing my job. I just got off work and am going to revise it. Thank you very much

[alamb]

I took the liberty of fixing the clippy error and merging this branch from main

Thank you for doing my job. I just got off work and am going to revise it. Thank you very much

No worries! I am just trying to keep the review backlog in DataFusion down -- our PR list is long at the moment so I am just trying to do anything I can to drive it lower

[alamb]

(I get very anxious when there are PRs waiting for reviews / merging in DataFusion -- 😅 )

[caicancai]

(I get very anxious when there are PRs waiting for reviews / merging in DataFusion -- 😅 )

arrow-datafusion is destined to be a good community. I also participate in the calcite community and hope to make more contributions to the arrow-datafusion community in the future.