Add FunctionRegistry::register_udaf and FunctionRegistry::register_udwf
#9075
Conversation
github-actions
bot
added
logical-expr
alamb
force-pushed
the
alamb/more_functions
branch
from
c0d88f7
to
7eeb52e
Compare
github-actions
bot
removed
logical-expr
| state | ||
| .scalar_functions | ||
| .insert(f.name().to_string(), Arc::new(f)); | ||
| state.register_udf(Arc::new(f)).ok(); |
There was a problem hiding this comment.
moved into SessionState -- it is important that the alias resolution is done there so when new functions are registered via SessionState their aliases are as well. Otherwise aliases are only added when the function is defined via SessionContext
| /// | ||
| /// Returns an error (the default) if the function can not be registered, | ||
| /// for example if the registry is read only. | ||
| fn register_udaf( |
There was a problem hiding this comment.
This is the key (backwards compatible) API addition in this PR.
It sets us up for being able to pull out BuiltInAggregate and BuiltInWindowFunction
There was a problem hiding this comment.
I'm wondering why this is a backwards compatible API? Does FunctionRegistry provide this API before?
There was a problem hiding this comment.
I think it is backwards compatible because it provides a default implementation (to return a Not Yet Implemented error)
Thus, any existing implementations of FunctionRegistry will continue to compile and work as it did before, without any required code changes
alamb
force-pushed
the
alamb/more_functions
branch
from
7eeb52e
to
4257c16
Compare
| let aliases = udf.aliases(); | ||
| for alias in aliases { | ||
| self.scalar_functions.insert(alias.to_string(), udf.clone()); | ||
| } |
Co-authored-by: comphead <comphead@users.noreply.github.com> Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
Which issue does this PR close?
Closes #9074
Part of #8045 (making functions modular in DataFusion)
Rationale for this change
See #9074 (basically set us up for pulling aggregates and window functions out of the core)
What changes are included in this PR?
FunctionRegistry::register_udafandFunctionRegistry::register_udwfSessionStateSessionContextto use that API rather than modifying session state directlyAre these changes tested?
Covered by existing tests
Are there any user-facing changes?