Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move asin() to function crate #9379

Merged
merged 1 commit into from
Feb 28, 2024
Merged

refactor: move asin() to function crate #9379

merged 1 commit into from
Feb 28, 2024

Conversation

SteveLauC
Copy link
Contributor

Which issue does this PR close?

Closes #9378

part of #9285

Rationale for this change

See #9285

What changes are included in this PR?

move asin() to function crate

Are these changes tested?

Are there any user-facing changes?

I guess no

@github-actions github-actions bot added logical-expr Logical plan and expressions physical-expr Physical Expressions labels Feb 28, 2024
jonahgao
jonahgao approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@SteveLauC
Copy link
Contributor Author

Thanks for your review! @jonahgao

@alamb alamb mentioned this pull request Feb 28, 2024
Closed
9 tasks
alamb
alamb approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SteveLauC and @jonahgao for the review

@alamb alamb merged commit 96abac8 into apache:main Feb 28, 2024
23 checks passed
@SteveLauC SteveLauC deleted the refactor/move_asin_to_functions_crate branch February 28, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahgao jonahgao jonahgao approved these changes

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
logical-expr Logical plan and expressions physical-expr Physical Expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port asin() to crate datafusion-functions
3 participants
@SteveLauC @alamb @jonahgao