Port ArraySort to function-arrays subcrate
#9551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
43 tasks
jayzhan211
reviewed
Mar 11, 2024
jayzhan211
reviewed
Mar 11, 2024
| @@ -182,7 +182,7 @@ CREATE TABLE array_agg_distinct_list_table AS VALUES | |||
| ('b', [0,1]) | |||
| ; | |||
|
|
|||
| # Apply array_sort to have determinisitic result, higher dimension nested array also works but not for array sort, | |||
| # Apply array_sort to have deterministic result, higher dimension nested array also works but not for array sort, | |||
jayzhan211
reviewed
Mar 11, 2024
|
Thanks @erenavsarogullari |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9550
What changes are included in this PR?
This PR aims to do following changes in terms of Epic #9285:
1-
ArraySortis ported tofunction-arrayssubcrate,2-
ScalarUDFImpl. return_typehas been implemented to support input types:List,FixedSizeListandLargeList,3- Function Documentation is updated.
Are these changes tested?
Yes, all
array.sltbasedarray_sorttests are passed.Are there any user-facing changes?
No