minor: Remove deprecated methods #9627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
comphead
commented
Mar 15, 2024
| @@ -399,20 +374,20 @@ mod test { | |||
| } | |||
|
|
|||
| #[test] | |||
| #[allow(deprecated)] | |||
| #[ignore = "investigate if this test is needed"] | |||
There was a problem hiding this comment.
The method which supposed to replace deprecated one is failing this test, investigating if this test makes sense any more
There was a problem hiding this comment.
I looked at this test and I think it should just be removed (as it is testing a behavior that was removed). The new behavior is covered by
#[test]
fn normalize_cols() {Right above it
There was a problem hiding this comment.
I pushed a commit to remove the test to your branch
alamb
reviewed
Mar 16, 2024
| @@ -399,20 +374,20 @@ mod test { | |||
| } | |||
|
|
|||
| #[test] | |||
| #[allow(deprecated)] | |||
| #[ignore = "investigate if this test is needed"] | |||
There was a problem hiding this comment.
I looked at this test and I think it should just be removed (as it is testing a behavior that was removed). The new behavior is covered by
#[test]
fn normalize_cols() {Right above it
| @@ -399,20 +374,20 @@ mod test { | |||
| } | |||
|
|
|||
| #[test] | |||
| #[allow(deprecated)] | |||
| #[ignore = "investigate if this test is needed"] | |||
There was a problem hiding this comment.
I pushed a commit to remove the test to your branch
alamb
approved these changes
Mar 16, 2024
Michael-J-Ward
added a commit
to Michael-J-Ward/datafusion-python
that referenced
this pull request
May 1, 2024
The suggested replacement `Session::catalog` is already included. Ref: apache/datafusion#9627
3 tasks
Michael-J-Ward
added a commit
to Michael-J-Ward/datafusion-python
that referenced
this pull request
May 8, 2024
The method was removed upstream but is used in many tests for `datafusion-python`. Ref: apache/datafusion#9627
andygrove
pushed a commit
to apache/datafusion-python
that referenced
this pull request
May 8, 2024
* deps: upgrade datafusion to 37.1.0 * feat: re-implement SessionContext::tables The method was removed upstream but is used in many tests for `datafusion-python`. Ref: apache/datafusion#9627 * feat: upgrade dataframe write_parquet and write_json The options to write_parquet changed. write_json has a new argument that I defaulted to None. We can expose that config later. Ref: apache/datafusion#9382 * feat: impl new ExecutionPlanProperties for DatasetExec Ref: apache/datafusion#9346 * feat: add upstream variant and method params - `WindowFunction` and `AggregateFunction` have `null_treatment` options. - `ScalarValue` and `DataType` have new variants - `SchemaProvider::table` now returns a `Result` * lint: allow(deprecated) for make_scalar_function * feat: migrate functions.rs `datafusion` completed an Epic that ported many of the `BuiltInFunctions` enum to `SclarUDF`. I created new macros to simplify the port, and used these macros to refactor a few existing functions. Ref: apache/datafusion#9285 * fixme: commented out last failing test This is a bug upstream in datafusion FAILED datafusion/tests/test_functions.py::test_array_functions - pyo3_runtime.PanicException: range end index 9 out of range for slice of length 8 * chore: update Cargo.toml package info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Some code can be removed from DF codebase as its deprecated long time ago
What changes are included in this PR?
Remove deprecated code up to DF 30.0.0 and fixed tests
Are these changes tested?
Yes
Are there any user-facing changes?