parquet: Add tests for page pruning on unsigned integers #9888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progval
commented
Mar 31, 2024
Comment on lines
+562
to
+584
| #[tokio::test] | ||
| async fn [<prune_uint $bits _scalar_fun_and_eq >]() { | ||
| test_prune( | ||
| Scenario::UInt, | ||
| &format!("SELECT * FROM t where power(u{}, 2) = 36 and u{} = 6", $bits, $bits), | ||
| Some(0), | ||
| Some(15), | ||
| 1, | ||
| ) | ||
| .await; | ||
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn [<prune_uint $bits _scalar_fun >]() { | ||
| test_prune( | ||
| Scenario::UInt, | ||
| &format!("SELECT * FROM t where power(u{}, 2) = 25", $bits), | ||
| Some(0), | ||
| Some(0), | ||
| 2, | ||
| ) | ||
| .await; | ||
| } |
There was a problem hiding this comment.
abs() doesn't really make sense on unsigned integers, so I replaced it with power() when adapting from signed integer tests
alamb
approved these changes
Mar 31, 2024
| paste::item! { | ||
| #[tokio::test] | ||
| // null count min max | ||
| // page-0 0 0 4 |
There was a problem hiding this comment.
I was confused at first, but the make_uint_batches(0, 5) returns 0..5 which has a max of 4. ✅
Comment on lines
+562
to
+584
| #[tokio::test] | ||
| async fn [<prune_uint $bits _scalar_fun_and_eq >]() { | ||
| test_prune( | ||
| Scenario::UInt, | ||
| &format!("SELECT * FROM t where power(u{}, 2) = 36 and u{} = 6", $bits, $bits), | ||
| Some(0), | ||
| Some(15), | ||
| 1, | ||
| ) | ||
| .await; | ||
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn [<prune_uint $bits _scalar_fun >]() { | ||
| test_prune( | ||
| Scenario::UInt, | ||
| &format!("SELECT * FROM t where power(u{}, 2) = 25", $bits), | ||
| Some(0), | ||
| Some(0), | ||
| 2, | ||
| ) | ||
| .await; | ||
| } |
Lordworms
pushed a commit
to Lordworms/arrow-datafusion
that referenced
this pull request
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9887.
Rationale for this change
What changes are included in this PR?
New test scenario, new tests adapted from the signed integer tests
Are these changes tested?
yes
Are there any user-facing changes?
no