Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DELTASPIKE-1473: Improved dependency consistency in the JSF module #160

Merged
merged 1 commit into from
May 21, 2024

Conversation

cmunier
Copy link
Contributor

@cmunier cmunier commented Apr 24, 2024

https://issues.apache.org/jira/browse/DELTASPIKE-1473

  • removed obsolete dependencies
  • added used transitive dependencies as explicite dependencies
  • narrowed down dependency scopes that were too broad

@@ -39,6 +39,62 @@
<module>impl</module>
</modules>

<build>
Copy link
Member

@tandraschko tandraschko May 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you remove this (enforcer + maven-dependency-plugin), i would merge it
we never had this and we would need a discussion; i'm not a fan of it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tandraschko,
I just removed the changes to the POMs in parent and modules/jsf.

If anyone likes the idea of enforcing those consistency rules, the proposed changes are still available in https://github.com/cmunier/deltaspike/tree/DELTASPIKE-1473-enforce-consistency.

I have had a good experience with using both enforced scopes and especially "dependency analyze" in several projects, as it is a measure that is low-effort and can be used selectively in part of a multi-module project.

- removed obsolete dependencies
- added used transitive dependencies as explicite dependencies
- narrowed down dependency scopes that were too broad
@cmunier cmunier force-pushed the DELTASPIKE-1473 branch from 90d3518 to a598e72 Compare May 14, 2024 18:28
@tandraschko tandraschko merged commit 0fa754f into apache:master May 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants