Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing key file in asdist subcommand #84

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

zhongjiajie
Copy link
Member

Brief Summary of The Change

Currently, missing license and notice in
python setup.py asdist command

Pull Request checklist

I confirm that the following checklist has been completed.

  • Add/Change test cases for the changes.
  • Add/Change the related documentation, should also change docs/source/config.rst when you change file default_config.yaml.
  • (Optional) Add your change to UPDATING.md when it is an incompatible change.

Currently, missing license and notice in
python setup.py asdist command
Copy link
Member

@jieguangzhou jieguangzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongjiajie zhongjiajie added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Mar 28, 2023
@zhongjiajie zhongjiajie merged commit f891014 into apache:main Mar 28, 2023
@zhongjiajie zhongjiajie deleted the asdist-missing-data branch March 28, 2023 03:04
zhongjiajie added a commit that referenced this pull request Oct 12, 2023
Currently, missing license and notice in
python setup.py asdist command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants