Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to #9801: fix delete job of quartz not work #10645

Merged
merged 1 commit into from
Jul 1, 2022
Merged

to #9801: fix delete job of quartz not work #10645

merged 1 commit into from
Jul 1, 2022

Conversation

zwZjut
Copy link
Contributor

@zwZjut zwZjut commented Jun 28, 2022

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (2.0.6-prepare@7d91ad3). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 839f4f4 differs from pull request most recent head 6246bd6. Consider uploading reports for the commit 6246bd6 to get more accurate results

@@               Coverage Diff                @@
##             2.0.6-prepare   #10645   +/-   ##
================================================
  Coverage                 ?   20.90%           
  Complexity               ?     1602           
================================================
  Files                    ?      540           
  Lines                    ?    22841           
  Branches                 ?     2714           
================================================
  Hits                     ?     4776           
  Misses                   ?    17574           
  Partials                 ?      491

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d91ad3...6246bd6. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 53 Bugs
Vulnerability B 6 Vulnerabilities
Security Hotspot E 11 Security Hotspots
Code Smell A 1320 Code Smells

19.3% 19.3% Coverage
4.5% 4.5% Duplication

@caishunfeng caishunfeng added this to the 2.0.6 milestone Jun 28, 2022
ruanwenjun
ruanwenjun approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun
Copy link
Member

This is strange, this PR doesn't change the dependency, but the license check failed.

brave-lee
brave-lee approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@brave-lee brave-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@brave-lee brave-lee merged commit 85d3637 into apache:2.0.6-prepare Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@brave-lee brave-lee brave-lee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.6
Development

Successfully merging this pull request may close these issues.
5 participants
@zwZjut @codecov-commenter @ruanwenjun @brave-lee @caishunfeng