-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] [Fix-10673] Workflow recovery bug with failed tasks #10722
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
if (processInstance.getCommandType() == CommandType.RECOVER_TOLERANCE_FAULT_PROCESS | ||
|| processInstance.getCommandType() == CommandType.RECOVER_SUSPENDED_PROCESS) { | ||
List<Integer> failedList = processService.findTaskIdByInstanceState(processInstance.getId(), ExecutionStatus.FAILURE); | ||
if (!failedList.isEmpty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!failedList.isEmpty()) { | |
if (CollectionUtil.isNotEmpty(failedList)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, some nip.
...er/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java
Show resolved
Hide resolved
SonarCloud Quality Gate failed. 53 Bugs |
closed by #10673