-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug][Api] fix NullPointException when deleting a workflow instance (… #15488
[Bug][Api] fix NullPointException when deleting a workflow instance (… #15488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI pass
hi @CommandCV plz run 'mvn spotless:apply' to fix these violations. |
Get! |
34a321c
to
2b0834c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15488 +/- ##
============================================
- Coverage 38.02% 38.02% -0.01%
Complexity 4688 4688
============================================
Files 1304 1304
Lines 44785 44786 +1
Branches 4801 4802 +1
============================================
Hits 17031 17031
- Misses 25903 25904 +1
Partials 1851 1851 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Good job, merged to dev. |
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md