Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Api] fix NullPointException when deleting a workflow instance (… #15488

Merged
merged 4 commits into from
Jan 17, 2024

Conversation

CommandCV
Copy link
Contributor

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

fuchanghai
fuchanghai previously approved these changes Jan 16, 2024
Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI pass

@fuchanghai
Copy link
Member

hi @CommandCV plz run 'mvn spotless:apply' to fix these violations.

@CommandCV
Copy link
Contributor Author

hi @CommandCV plz run 'mvn spotless:apply' to fix these violations.

Get!

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c7a11ce) 38.02% compared to head (75bd3b6) 38.02%.

❗ Current head 75bd3b6 differs from pull request most recent head 2eb19ce. Consider uploading reports for the commit 2eb19ce to get more accurate results

Files Patch % Lines
...uler/api/service/impl/TaskInstanceServiceImpl.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15488      +/-   ##
============================================
- Coverage     38.02%   38.02%   -0.01%     
  Complexity     4688     4688              
============================================
  Files          1304     1304              
  Lines         44785    44786       +1     
  Branches       4801     4802       +1     
============================================
  Hits          17031    17031              
- Misses        25903    25904       +1     
  Partials       1851     1851              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuchanghai fuchanghai added the bug Something isn't working label Jan 17, 2024
Copy link

sonarcloud bot commented Jan 17, 2024

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ruanwenjun ruanwenjun merged commit e1fcd4e into apache:dev Jan 17, 2024
56 checks passed
@ruanwenjun
Copy link
Member

Good job, merged to dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [API] NullPointException when deleting a workflow instance
5 participants