[Improvement-16746][seatunnel] pass user defined task parameter to seatunnel #16756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liunaijie
requested review from
caishunfeng,
SbloodyS and
Gallardot
as code owners
liunaijie
changed the title
|
will add test cast when this pr #16741 merged |
liunaijie
force-pushed
the
improve/seatunnel_parameter
branch
from
6ba1441
to
ce4a9fb
Compare
liunaijie
force-pushed
the
improve/seatunnel_parameter
branch
2 times, most recently
from
2df947d
to
d253d9d
Compare
SbloodyS
reviewed
Nov 1, 2024
...seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/SeatunnelTask.java
Show resolved
Hide resolved
ruanwenjun
requested changes
Nov 5, 2024
...seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/SeatunnelTask.java
Show resolved
Hide resolved
liunaijie
force-pushed
the
improve/seatunnel_parameter
branch
from
0da77e3
to
f58b5d5
Compare
|
Hisoka-X
reviewed
Nov 6, 2024
| > Click [here](https://seatunnel.apache.org/docs/2.3.3/command/usage) for more information on the usage of | ||
|
|
||
| `Apache SeaTunnel command` | ||
| > Click [here](https://seatunnel.apache.org/docs/2.3.3/command/usage) for more information on the usage of Apache SeaTunnel command` |
There was a problem hiding this comment.
Hi @liunaijie , how about update the doc version to 2.3.8?
There was a problem hiding this comment.
We can remove the version path, update to
https://seatunnel.apache.org/docs/command/usage/
This link will always avaliable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #16746
pass the user defined parameter in local parameter, global parameter to seatunnel shell command.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md