Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement-16757][Deploy] Avoid overwrite gc log #16788

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

deng-jeffer
Copy link
Contributor

@deng-jeffer deng-jeffer commented Nov 7, 2024

Purpose of the pull request

fix #16757

This pull request will avoid overwrite gc log when the server restart.
original gc logfile:gc.log
new gc logfile:gc-2024-11-07_10-40-39.log

Copy link

boring-cyborg bot commented Nov 7, 2024

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

@SbloodyS SbloodyS changed the title [Improvement-16757][Deploy]Avoid overwrite gc log [Improvement-16757][Deploy] Avoid overwrite gc log Nov 7, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Nov 7, 2024
@SbloodyS SbloodyS added first time contributor First-time contributor improvement make more easy to user or prompt friendly labels Nov 7, 2024
Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job, thanks for your first contribution.
LGTM

Copy link

sonarcloud bot commented Nov 7, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 53efdaa into apache:dev Nov 7, 2024
67 of 68 checks passed
Copy link

boring-cyborg bot commented Nov 7, 2024

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend first time contributor First-time contributor improvement make more easy to user or prompt friendly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement][Deploy] Avoid overwrite gc log
4 participants