Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug-8645][Api] Resource Re Upload, name duplicate #8811

Merged
merged 8 commits into from
Mar 10, 2022

Conversation

zhanqian-1993
Copy link
Contributor

@zhanqian-1993 zhanqian-1993 commented Mar 10, 2022

Purpose of the pull request

#8645

Brief change log

Resource ReUpload, allow duplicate file names(rename upload file name)

@zhanqian-1993 zhanqian-1993 changed the title Resource Re Upload, name duplicate #8645 Resource Re Upload, name duplicate Mar 10, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #8811 (1e02d76) into dev (bb1ba96) will increase coverage by 0.01%.
The diff coverage is 20.00%.

❗ Current head 1e02d76 differs from pull request most recent head ba50cb1. Consider uploading reports for the commit ba50cb1 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #8811      +/-   ##
============================================
+ Coverage     45.29%   45.31%   +0.01%     
- Complexity     4075     4076       +1     
============================================
  Files           702      702              
  Lines         27110    27111       +1     
  Branches       2897     2897              
============================================
+ Hits          12280    12284       +4     
+ Misses        13676    13674       -2     
+ Partials       1154     1153       -1     
Impacted Files Coverage Δ
...api/service/impl/ProcessDefinitionServiceImpl.java 31.90% <0.00%> (-0.03%) ⬇️
...inscheduler/api/service/impl/UsersServiceImpl.java 74.89% <100.00%> (+0.20%) ⬆️
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.81% <0.00%> (+2.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb1ba96...ba50cb1. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@caishunfeng caishunfeng changed the title Resource Re Upload, name duplicate [Bug-8645][Api] Resource Re Upload, name duplicate Mar 10, 2022
Copy link
Contributor

@brave-lee brave-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@brave-lee brave-lee merged commit e466f54 into apache:dev Mar 10, 2022
@brave-lee brave-lee added this to the 2.0.6-release milestone Mar 11, 2022
brave-lee pushed a commit to brave-lee/dolphinscheduler that referenced this pull request Jul 3, 2022
Co-authored-by: 北笙 <“zhanqian@cai-inc.com”>
Co-authored-by: zhanqian <zhanqian@cai-inc.com>
lenboo pushed a commit that referenced this pull request Jul 3, 2022
* issue 8645 (#8811)

Co-authored-by: 北笙 <“zhanqian@cai-inc.com”>
Co-authored-by: zhanqian <zhanqian@cai-inc.com>

* [fix-8929][DAO]Description Failed to upload the file because the full name was too long (#9020)

* [fix-8929][DAO]Description Failed to upload the file because the full name was too long

* [DS-#8929][fix]Description Failed to upload the file because the full name was too long

* [DS-#8929][fix]Description Failed to upload the file because the full name was too long

* [DS-#8929][fix]Description Failed to upload the file because the full name was too long

Co-authored-by: houshuai <houshuai@jiguang.cn>

* [BUG][ALERT-SERVER]validate script before alert script (#9834)

* validate script before alert script

* fix validate script before alert script

* pick 8811/9020/9834

Co-authored-by: zhanqian <360400325@qq.com>
Co-authored-by: 北笙 <“zhanqian@cai-inc.com”>
Co-authored-by: zhanqian <zhanqian@cai-inc.com>
Co-authored-by: shuai hou <120306274@qq.com>
Co-authored-by: houshuai <houshuai@jiguang.cn>
Co-authored-by: Tq <tianqitobethefirst@gmail.com>
Co-authored-by: JinyLeeChina <jiny.li@foxmail.com>
brave-lee added a commit that referenced this pull request Jul 4, 2022
* issue 8645 (#8811)

Co-authored-by: 北笙 <“zhanqian@cai-inc.com”>
Co-authored-by: zhanqian <zhanqian@cai-inc.com>

* [fix-8929][DAO]Description Failed to upload the file because the full name was too long (#9020)

* [fix-8929][DAO]Description Failed to upload the file because the full name was too long

* [DS-#8929][fix]Description Failed to upload the file because the full name was too long

* [DS-#8929][fix]Description Failed to upload the file because the full name was too long

* [DS-#8929][fix]Description Failed to upload the file because the full name was too long

Co-authored-by: houshuai <houshuai@jiguang.cn>

* [BUG][ALERT-SERVER]validate script before alert script (#9834)

* validate script before alert script

* fix validate script before alert script

* pick 8811/9020/9834

* fix ut

* fix pick error

Co-authored-by: zhanqian <360400325@qq.com>
Co-authored-by: 北笙 <“zhanqian@cai-inc.com”>
Co-authored-by: zhanqian <zhanqian@cai-inc.com>
Co-authored-by: shuai hou <120306274@qq.com>
Co-authored-by: houshuai <houshuai@jiguang.cn>
Co-authored-by: Tq <tianqitobethefirst@gmail.com>
Co-authored-by: JinyLeeChina <jiny.li@foxmail.com>
zhongjiajie pushed a commit that referenced this pull request Jul 4, 2022
* issue 8645 (#8811)

Co-authored-by: 北笙 <“zhanqian@cai-inc.com”>
Co-authored-by: zhanqian <zhanqian@cai-inc.com>

* [fix-8929][DAO]Description Failed to upload the file because the full name was too long (#9020)

* [fix-8929][DAO]Description Failed to upload the file because the full name was too long

* [DS-#8929][fix]Description Failed to upload the file because the full name was too long

* [DS-#8929][fix]Description Failed to upload the file because the full name was too long

* [DS-#8929][fix]Description Failed to upload the file because the full name was too long

Co-authored-by: houshuai <houshuai@jiguang.cn>

* [BUG][ALERT-SERVER]validate script before alert script (#9834)

* validate script before alert script

* fix validate script before alert script

* pick 8811/9020/9834

* fix ut

* fix pick error

* fix 10762

Co-authored-by: zhanqian <360400325@qq.com>
Co-authored-by: 北笙 <“zhanqian@cai-inc.com”>
Co-authored-by: zhanqian <zhanqian@cai-inc.com>
Co-authored-by: shuai hou <120306274@qq.com>
Co-authored-by: houshuai <houshuai@jiguang.cn>
Co-authored-by: Tq <tianqitobethefirst@gmail.com>
Co-authored-by: JinyLeeChina <jiny.li@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants