Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-8544][API] The folder's size can't be updated when creating, updating or deleting a resource file int the folder. #9107

Merged
merged 6 commits into from
Mar 23, 2022

Conversation

calvinjiang
Copy link
Contributor

Purpose of the pull request

This PR will close #8544 .

Brief change log

When creating, updating or deleting a resource file in a folder, the folder's size wouldn't be updated. Because the back-end service didn't handle that.
First of all I add the function to update the folder's size when creating, updating or deleting a resource file in a folder.
Second I add the repairing mechanisms to repair that issue of the previous version when users choose to upgrade the system from the version below '2.0.6'.

Verify this pull request

This change added tests and can be verified as follows:

  • Manually verified the change by testing locally.

The test results are as follows:
image

image

@songjianet songjianet added bug Something isn't working backend labels Mar 23, 2022
@mergeable mergeable bot removed bug Something isn't working backend labels Mar 23, 2022
@songjianet songjianet added bug Something isn't working backend labels Mar 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2022

Codecov Report

Merging #9107 (fdab7ba) into dev (3c377ff) will decrease coverage by 0.01%.
The diff coverage is 40.90%.

@@             Coverage Diff              @@
##                dev    #9107      +/-   ##
============================================
- Coverage     40.28%   40.27%   -0.02%     
+ Complexity     4366     4365       -1     
============================================
  Files           808      808              
  Lines         32547    32569      +22     
  Branches       3646     3650       +4     
============================================
+ Hits          13113    13117       +4     
- Misses        18208    18223      +15     
- Partials       1226     1229       +3     
Impacted Files Coverage Δ
...heduler/api/service/impl/ResourcesServiceImpl.java 53.24% <40.90%> (-0.43%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.70% <0.00%> (-2.82%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 56.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c377ff...fdab7ba. Read the comment docs.

Copy link
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

15.8% 15.8% Coverage
14.1% 14.1% Duplication

@zhuangchong zhuangchong added this to the 2.0.6-release milestone Mar 23, 2022
@zhuangchong zhuangchong merged commit 7c5bebe into apache:dev Mar 23, 2022
zhuangchong added a commit to zhuangchong/incubator-dolphinscheduler that referenced this pull request Jul 4, 2022
brave-lee pushed a commit that referenced this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Resource Center-UDF Management/Resource Management] Folder size statistics error
4 participants