[feat](skew & kurt) New aggregate function skew & kurt #40945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 41559 ms |
TPC-DS: Total hot run time: 193943 ms |
ClickBench: Total hot run time: 31.75 s |
|
TeamCity be ut coverage result: |
zhiqiang-hhhh
force-pushed
the
feat-agg
branch
from
4ae074e
to
c5fa11c
Compare
|
run buildall |
TPC-H: Total hot run time: 41954 ms |
TPC-DS: Total hot run time: 194990 ms |
ClickBench: Total hot run time: 32.71 s |
|
TeamCity be ut coverage result: |
HappenLee
reviewed
Sep 20, 2024
|
|
||
| namespace doris::vectorized { | ||
|
|
||
| enum class StatisticsFunctionKind : uint8_t { skewPop, kurtPop }; |
HappenLee
reviewed
Sep 20, 2024
|
|
||
| namespace doris::vectorized { | ||
|
|
||
| enum class StatisticsFunctionKind : uint8_t { skewPop, kurtPop }; |
There was a problem hiding this comment.
renamed to STATISTICS_FUNCTION_KIND
HappenLee
reviewed
Sep 20, 2024
|
|
||
| template <typename T, std::size_t _level> | ||
| struct StatFuncOneArg { | ||
| using Type1 = T; |
There was a problem hiding this comment.
same type, no need two type
| } | ||
| } | ||
|
|
||
| void reset() { return; } |
There was a problem hiding this comment.
this function is usefully, should reset all m to init val
| using ResultType = Float64; | ||
| using Data = VarMoments<ResultType, _level>; | ||
|
|
||
| static constexpr UInt32 num_args = 1; |
There was a problem hiding this comment.
seems not use this var?
| using ColVecT1 = ColumnVectorOrDecimal<T1>; | ||
| using ColVecT2 = ColumnVectorOrDecimal<T2>; | ||
| using ResultType = typename StatFunc::ResultType; | ||
| using ColVecResult = ColumnVector<ResultType>; |
There was a problem hiding this comment.
here seems could write more simple code,
as the two function return type is ColumnFloat64
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/Skew.java
Show resolved
Hide resolved
| implements UnaryExpression, ExplicitlyCastableSignature, AlwaysNullable { | ||
|
|
||
| public static final List<FunctionSignature> SIGNATURES = ImmutableList.of( | ||
| FunctionSignature.ret(DoubleType.INSTANCE).args(FloatType.INSTANCE), |
There was a problem hiding this comment.
could let FE members check the args order, #39352
There was a problem hiding this comment.
now same with 39352
HappenLee
reviewed
Sep 20, 2024
|
|
||
| void add(AggregateDataPtr __restrict place, const IColumn** columns, ssize_t row_num, | ||
| Arena*) const override { | ||
| if constexpr (NullableInput) { |
There was a problem hiding this comment.
should skip the null value
There was a problem hiding this comment.
this function is using creator_without_type::create_ignore_nullable, aggregate_function_null will not be used since this return type is always nullable.
HappenLee
reviewed
Sep 20, 2024
| "'getPopulation' method"); | ||
| } | ||
|
|
||
| T getPopulation() const { |
|
run buildall |
6 tasks
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41903 ms |
TPC-DS: Total hot run time: 195972 ms |
zhiqiang-hhhh
dismissed stale reviews from HappenLee and zhangstar333
via
42228ba
|
run buildall |
github-actions
bot
removed
the
approved
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41536 ms |
TPC-DS: Total hot run time: 191403 ms |
ClickBench: Total hot run time: 33.05 s |
|
run p0 |
zhangstar333
approved these changes
Sep 24, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
zhiqiang-hhhh
added a commit
to zhiqiang-hhhh/doris
that referenced
this pull request
Sep 25, 2024
`skew`,`skew_pop` and `skewness` is used to calculate [skewness](https://en.wikipedia.org/wiki/Skewness#Pearson.27s_moment_coefficient_of_skewness) of a data distribution. `kurt`,`kurt_pop` and `kurtosis` is used to calculate [kurtosis](https://en.wikipedia.org/wiki/Kurtosis) of a data distribution. The implementation references ClickHouse/ClickHouse#5200, and modified result type to AlwaysNullable since doris do not support NaN. The formula used to calculate skew is `3-th moments / (variance^{1.5})` The formula used to calculate kurt is `4-th moments / (variance^{2}) - 3` when value of any result is NaN, doris will return NULL. doc: apache/doris-website#1127
This was referenced Sep 25, 2024
zhiqiang-hhhh
added a commit
to zhiqiang-hhhh/doris
that referenced
this pull request
Sep 25, 2024
`skew`,`skew_pop` and `skewness` is used to calculate [skewness](https://en.wikipedia.org/wiki/Skewness#Pearson.27s_moment_coefficient_of_skewness) of a data distribution. `kurt`,`kurt_pop` and `kurtosis` is used to calculate [kurtosis](https://en.wikipedia.org/wiki/Kurtosis) of a data distribution. The implementation references ClickHouse/ClickHouse#5200, and modified result type to AlwaysNullable since doris do not support NaN. The formula used to calculate skew is `3-th moments / (variance^{1.5})` The formula used to calculate kurt is `4-th moments / (variance^{2}) - 3` when value of any result is NaN, doris will return NULL. doc: apache/doris-website#1127
morningman
pushed a commit
to apache/doris-website
that referenced
this pull request
Sep 26, 2024
# Versions - [x] dev - [x] 3.0 - [ ] 2.1 - [ ] 2.0 # Languages - [x] Chinese - [x] English ref apache/doris#40945
zhiqiang-hhhh
added a commit
to zhiqiang-hhhh/doris
that referenced
this pull request
Sep 26, 2024
`skew`,`skew_pop` and `skewness` is used to calculate [skewness](https://en.wikipedia.org/wiki/Skewness#Pearson.27s_moment_coefficient_of_skewness) of a data distribution. `kurt`,`kurt_pop` and `kurtosis` is used to calculate [kurtosis](https://en.wikipedia.org/wiki/Kurtosis) of a data distribution. The implementation references ClickHouse/ClickHouse#5200, and modified result type to AlwaysNullable since doris do not support NaN. The formula used to calculate skew is `3-th moments / (variance^{1.5})` The formula used to calculate kurt is `4-th moments / (variance^{2}) - 3` when value of any result is NaN, doris will return NULL. doc: apache/doris-website#1127
zhiqiang-hhhh
added a commit
to zhiqiang-hhhh/doris
that referenced
this pull request
Sep 27, 2024
`skew`,`skew_pop` and `skewness` is used to calculate [skewness](https://en.wikipedia.org/wiki/Skewness#Pearson.27s_moment_coefficient_of_skewness) of a data distribution. `kurt`,`kurt_pop` and `kurtosis` is used to calculate [kurtosis](https://en.wikipedia.org/wiki/Kurtosis) of a data distribution. The implementation references ClickHouse/ClickHouse#5200, and modified result type to AlwaysNullable since doris do not support NaN. The formula used to calculate skew is `3-th moments / (variance^{1.5})` The formula used to calculate kurt is `4-th moments / (variance^{2}) - 3` when value of any result is NaN, doris will return NULL. doc: apache/doris-website#1127
dataroaring
pushed a commit
that referenced
this pull request
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skew,skew_popandskewnessis used to calculate skewness of a data distribution.kurt,kurt_popandkurtosisis used to calculate kurtosis of a data distribution.The implementation references ClickHouse/ClickHouse#5200, and modified result type to AlwaysNullable since doris do not support NaN.
The formula used to calculate skew is
3-th moments / (variance^{1.5})The formula used to calculate kurt is
4-th moments / (variance^{2}) - 3when value of any result is NaN, doris will return NULL.
doc: apache/doris-website#1127