-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve](txn insert) make sub transactions visible #41362
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TeamCity be ut coverage result: |
468f4a1
to
7646c20
Compare
run buildall |
TeamCity be ut coverage result: |
@@ -1743,6 +1745,9 @@ public void setEnableLeftZigZag(boolean enableLeftZigZag) { | |||
@VariableMgr.VarAttr(name = GROUP_COMMIT, needForward = true) | |||
public String groupCommit = "off_mode"; | |||
|
|||
@VariableMgr.VarAttr(name = ENABLE_QUERY_IN_TRANSACTION_LOAD, needForward = true) | |||
public boolean enableQueryInTransactionLoad = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default should be true.
ConnectContext.get().getTxnEntry().getTabletSubTxnIds(olapTable.getId(), tablet)); | ||
LOG.info("table={}, partition={}, tablet={}, sub txn ids={}", olapTable.getId(), partition.getId(), | ||
tablet.getId(), paloRange.getSubTxnIds()); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should assure that select in txn is forwarded to master too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the observer also knows the sub txn info
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PruneEmptyPartition.java
Show resolved
Hide resolved
be/src/olap/tablet.cpp
Outdated
DCHECK(rowset != nullptr) << " rowset is nullptr for sub_txn_id=" << sub_txn_ids[i] | ||
<< ", partition_id=" << partition_id() | ||
<< ", tablet=" << tablet_id(); | ||
int64_t tmp_version = version + i + 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version has already been added in prallel_scanner_builder _build_scanners_by_rowid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_load is called firstly, now version is not changed
fe/fe-core/src/main/java/org/apache/doris/transaction/TransactionEntry.java
Show resolved
Hide resolved
58694e1
to
3b07d43
Compare
run buildall |
TeamCity be ut coverage result: |
run buildall |
TeamCity be ut coverage result: |
78739c1
to
b730606
Compare
b730606
to
db8cdc0
Compare
run buildall |
TeamCity be ut coverage result: |
No description provided.