Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve](txn insert) make sub transactions visible #41362

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Sep 26, 2024

No description provided.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Sep 26, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.31% (9635/25827)
Line Coverage: 28.70% (79715/277800)
Region Coverage: 28.12% (41217/146573)
Branch Coverage: 24.75% (20989/84804)
Coverage Report: http://coverage.selectdb-in.cc/coverage/468f4a1ee092489aeb84d542f4c98fb7d4593b82_468f4a1ee092489aeb84d542f4c98fb7d4593b82/report/index.html

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Sep 27, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.29% (9627/25815)
Line Coverage: 28.68% (79665/277737)
Region Coverage: 28.12% (41191/146504)
Branch Coverage: 24.74% (20973/84788)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7646c207b62a29bf04a45757bfe5eef2e8e9489b_7646c207b62a29bf04a45757bfe5eef2e8e9489b/report/index.html

@@ -1743,6 +1745,9 @@ public void setEnableLeftZigZag(boolean enableLeftZigZag) {
@VariableMgr.VarAttr(name = GROUP_COMMIT, needForward = true)
public String groupCommit = "off_mode";

@VariableMgr.VarAttr(name = ENABLE_QUERY_IN_TRANSACTION_LOAD, needForward = true)
public boolean enableQueryInTransactionLoad = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default should be true.

ConnectContext.get().getTxnEntry().getTabletSubTxnIds(olapTable.getId(), tablet));
LOG.info("table={}, partition={}, tablet={}, sub txn ids={}", olapTable.getId(), partition.getId(),
tablet.getId(), paloRange.getSubTxnIds());
}

Copy link
Contributor

@dataroaring dataroaring Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should assure that select in txn is forwarded to master too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the observer also knows the sub txn info

DCHECK(rowset != nullptr) << " rowset is nullptr for sub_txn_id=" << sub_txn_ids[i]
<< ", partition_id=" << partition_id()
<< ", tablet=" << tablet_id();
int64_t tmp_version = version + i + 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version has already been added in prallel_scanner_builder _build_scanners_by_rowid.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_load is called firstly, now version is not changed

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Sep 29, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.29% (9627/25820)
Line Coverage: 28.67% (79675/277888)
Region Coverage: 28.11% (41208/146593)
Branch Coverage: 24.73% (20982/84848)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3b07d43331c05277cc24a34fb911921877e73809_3b07d43331c05277cc24a34fb911921877e73809/report/index.html

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Sep 29, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.28% (9625/25820)
Line Coverage: 28.68% (79689/277888)
Region Coverage: 28.11% (41202/146593)
Branch Coverage: 24.72% (20976/84848)
Coverage Report: http://coverage.selectdb-in.cc/coverage/78739c1820daadfd7345065e11f836ab27e2a2a7_78739c1820daadfd7345065e11f836ab27e2a2a7/report/index.html

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Sep 30, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.31% (9631/25811)
Line Coverage: 28.68% (79853/278428)
Region Coverage: 28.13% (41301/146824)
Branch Coverage: 24.75% (21043/85018)
Coverage Report: http://coverage.selectdb-in.cc/coverage/db8cdc062e4c6790ffc93255722c460ee3a49c5a_db8cdc062e4c6790ffc93255722c460ee3a49c5a/report/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants