-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](schema-change) fix the bug of alter column nullable when double writing (#41737) #42351
[fix](schema-change) fix the bug of alter column nullable when double writing (#41737) #42351
Conversation
… writing (apache#41737) CREATE TABLE t ( `k1` VARCHAR(30) NOT NULL, `v1` INT NOT NULL ) alter table t modify column `v1` INT NULL insert into value ('1', 2), ('1', 3); core dump Schema change leads to double writing, during double writing, the two schemas and slots are as follows ``` old tablet schema k1 varchar not null v1 int not null ``` ``` new tablet scheam k1 varchar not null v1 int null ``` ``` slot k1 varchar not null v1 int not null v1 int null ``` During the double writing process, when selecting slots through the schema, only the column names and types were compared, without comparing the nullable attributes, which led to the selection of the wrong slot. Since the slot determines the nullable attribute of the block, the nullable attribute of the columns in the block is different from that of the columns in the schema, resulting in a core dump.
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 49227 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 213659 ms
|
ClickBench: Total hot run time: 30.49 s
|
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 48968 ms
|
TPC-DS: Total hot run time: 211758 ms
|
ClickBench: Total hot run time: 31.01 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 48984 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 212059 ms
|
ClickBench: Total hot run time: 31.43 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
pick master #41737