-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](load) fix broker load progress due to retry #42959
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 42561 ms
|
TPC-DS: Total hot run time: 196639 ms
|
ClickBench: Total hot run time: 33.31 s
|
run buildall |
TPC-H: Total hot run time: 41285 ms
|
TPC-DS: Total hot run time: 190695 ms
|
ClickBench: Total hot run time: 32.63 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
## Proposed changes Currently, when retrying a broker load, it will use a different `load_id` with the same `job_id`. The `total_scan_nums` in progress is accumulated by `job_id`. This will cause the `total_scan_nums` progress to be multiple of the actual scan nums. For example, suppose a 10 instance broker load gets retried: ``` initial (0/10) 0% -> retry (0/20) 0% -> finish (10/20) 50% ```
Cherry-picked from #42959 Co-authored-by: Kaijie Chen <ckj@apache.org>
Currently, when retrying a broker load, it will use a different `load_id` with the same `job_id`. The `total_scan_nums` in progress is accumulated by `job_id`. This will cause the `total_scan_nums` progress to be multiple of the actual scan nums. For example, suppose a 10 instance broker load gets retried: ``` initial (0/10) 0% -> retry (0/20) 0% -> finish (10/20) 50% ```
Currently, when retrying a broker load, it will use a different `load_id` with the same `job_id`. The `total_scan_nums` in progress is accumulated by `job_id`. This will cause the `total_scan_nums` progress to be multiple of the actual scan nums. For example, suppose a 10 instance broker load gets retried: ``` initial (0/10) 0% -> retry (0/20) 0% -> finish (10/20) 50% ```
Proposed changes
Currently, when retrying a broker load, it will use a different
load_id
with the samejob_id
.The
total_scan_nums
in progress is accumulated byjob_id
.This will cause the
total_scan_nums
progress to be multiple of the actual scan nums.For example, suppose a 10 instance broker load gets retried: