Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore](sink) enable_parallel_result_sink default value is changed to false #43933

Merged
merged 2 commits into from
Nov 19, 2024
Merged

[chore](sink) enable_parallel_result_sink default value is changed to false #43933

merged 2 commits into from
Nov 19, 2024
+29 −3

Conversation

xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented Nov 14, 2024 •
edited
Loading

What problem does this PR solve?

Problem Summary:

For most queries, result sink will not become a performance bottleneck, but the parallel result sink will increase the pressure of RPC between fe and be.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@xinyiZzz
Copy link
Contributor Author

run buildall

1 similar comment
@xinyiZzz
Copy link
Contributor Author

run buildall

@xinyiZzz
Copy link
Contributor Author

run buildall

1 similar comment
@xinyiZzz
Copy link
Contributor Author

run buildall

@xinyiZzz
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

wangbo
wangbo approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinyiZzz xinyiZzz merged commit faa8a64 into apache:master Nov 19, 2024
26 of 28 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
@xinyiZzz
[chore](sink) enable_parallel_result_sink default value is changed …
0bdeb04 
…to false (#43933)

### What problem does this PR solve?

Problem Summary:

For most queries, result sink will not become a performance bottleneck,
but the parallel result sink will increase the pressure of RPC between
fe and be.
@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Open
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request Nov 19, 2024
@xinyiZzz
[chore](sink) enable_parallel_result_sink default value is changed …
d8438d0 
…to false (apache#43933)

### What problem does this PR solve?

Problem Summary:

For most queries, result sink will not become a performance bottleneck,
but the parallel result sink will increase the pressure of RPC between
fe and be.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangbo wangbo wangbo approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.x reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xinyiZzz @doris-robot @yiguolei @wangbo