Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve](binlog) Reserve ids for binlog type allocation #43769 #44104

Merged
merged 1 commit into from
Nov 18, 2024
Merged

[improve](binlog) Reserve ids for binlog type allocation #43769 #44104

merged 1 commit into from
Nov 18, 2024

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Nov 18, 2024

cherry pick from #43769

@w41ter
[improve](binlog) Reserve ids for binlog type allocation (apache#43769)
205e967 
### What problem does this PR solve?

Problem Summary:

Keep some IDs for allocation so that when new binlog types are added in
the future, the changes can be picked back to the old versions without
breaking compatibility.

The code will check the IDs of binlog types. Any binlog types whose IDs
are greater than or equal to MIN_UNKNOWN will be ignored.
@w41ter
Copy link
Contributor Author

w41ter commented Nov 18, 2024

run buildall

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@w41ter w41ter merged commit 4458131 into apache:branch-2.0 Nov 18, 2024
21 of 24 checks passed
@w41ter w41ter deleted the pick_43769_to_origin_branch-2.0 branch November 18, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@w41ter @doris-robot