Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "always set taskLocation (#17350)" #17417

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

georgew5656
Copy link
Contributor

This reverts commit a664fc8.

Description

The reverted commit can cause issues when overlords with a lot of tasks restart because of the flood of calls to k8s. This also combines with another bug when saveLogs() is called with a running task that causes the task to get stuck in a pending state.

I'm planning on fixing the saveLogs bug in a separate PR + address the original issue this commit tried to fix with a different approach, but for now reverting this change because it seems to cause more issues than it solves.

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

  • fix a bug during overlord restarts introduced by the previous change
Key changed/added classes in this PR
  • KubernetesPeonLifecyle

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@suneet-s
Copy link
Contributor

Reverts #17350

@georgew5656
Copy link
Contributor Author

@georgew5656 georgew5656 reopened this Oct 29, 2024
@georgew5656 georgew5656 merged commit 66eb365 into apache:master Oct 29, 2024
110 of 111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants