Revert "always set taskLocation (#17350)" #17417
Merged
+99
−70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a664fc8.
Description
The reverted commit can cause issues when overlords with a lot of tasks restart because of the flood of calls to k8s. This also combines with another bug when saveLogs() is called with a running task that causes the task to get stuck in a pending state.
I'm planning on fixing the saveLogs bug in a separate PR + address the original issue this commit tried to fix with a different approach, but for now reverting this change because it seems to cause more issues than it solves.
Fixed the bug ...
Renamed the class ...
Added a forbidden-apis entry ...
Key changed/added classes in this PR
KubernetesPeonLifecyle
This PR has: