Add datasegment copier interface and s3 impl #17430
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtuglu-netflix
force-pushed
the
add-datasegment-copier-interface-and-s3-impl
branch
from
3cd35c3
to
a2534fb
Compare
jtuglu-netflix
force-pushed
the
add-datasegment-copier-interface-and-s3-impl
branch
from
a2534fb
to
49c7941
Compare
|
Thanks for the PR @jtuglu-netflix ! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ); | ||
| } | ||
| catch (Exception e) { | ||
| Throwables.propagateIfInstanceOf(e, AmazonServiceException.class); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| } | ||
| catch (Exception e) { | ||
| Throwables.propagateIfInstanceOf(e, AmazonServiceException.class); | ||
| Throwables.propagateIfInstanceOf(e, SegmentLoadingException.class); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
|
|
||
| private MockAmazonS3Client() | ||
| { | ||
| super(new AmazonS3Client(), new NoopServerSideEncryption()); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note test
jtuglu-netflix
force-pushed
the
add-datasegment-copier-interface-and-s3-impl
branch
from
af56f75
to
ec80d2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a DataSegmentCopier interface, and corresponding S3DataSegmentCopier implementation. The goal here is to provide an alternative for those wishing to move datasegments around between clusters. These classes are used in a CLI tool for copying datasources between clusters that was similar to the older, now-deprecated migration tool and plan to release that to open-source soon as well.
Description
Currently, Druid only provides a means of moving (deleting from the source) a datasegment from one deep storage location to another. This adds flexibility to copy instead, while refactoring the code between
S3DataSegmentMoverandS3DataSegmentCopierto be shared insideS3DataSegmentTransferUtility.Release note
Key changed/added classes in this PR
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/S3DataSegmentCopier.javaextensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/S3DataSegmentMover.javaextensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/S3DataSegmentTransferUtility.javaextensions-core/s3-extensions/src/test/java/org/apache/druid/storage/s3/S3DataSegmentCopierTest.javaprocessing/src/main/java/org/apache/druid/segment/loading/DataSegmentCopier.javaThis PR has: