support clean encoder/decoder, discard decode buffer #242
Conversation
wongoo
requested review from
AlexStocks,
fangyincheng,
zouyx and
zonghaishang
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
+ Coverage 66.18% 66.24% +0.06%
==========================================
Files 25 25
Lines 2768 2770 +2
==========================================
+ Hits 1832 1835 +3
- Misses 708 709 +1
+ Partials 228 226 -2
Continue to review full report at Codecov.
|
wongoo
changed the title
wongoo
changed the title
| assert.True(t, reflect.DeepEqual(u, res)) | ||
|
|
||
| // -------- decode 2 | ||
| d.Clean() |
There was a problem hiding this comment.
Why is' clean 'called once per decode.
If you have a complex object type, such as an object with multiple instance arrays, after the first instance is decoded, clean is called, will the decoding of subsequent instances fail?
There was a problem hiding this comment.
a multiple instance arrays should be considered as a whole object, and will be all decoded in once.
A call fo Clean means a new start for a new object.
|
@AlexStocks there is a CI error |
|
@AlexStocks @zonghaishang this pr Expose the api |
PR step can not get access_token |
support clean encoder/decoder, discard decode buffer
What this PR does:
support loop encoding&decoding
Which issue(s) this PR fixes:
Fixes #241
Special notes for your reviewer:
Does this PR introduce a user-facing change?: