-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #232 Add go struct refer to java.util.UUID #256
Conversation
…ut Year and testFunc
Feature/issue193
# Conflicts: # java8_time.go # java8_time/year.go # java8_time_test.go # test_hessian/src/main/java/test/Hessian.java # test_hessian/src/main/java/test/TestJava8Time.java
…-chen/dubbo-go-hessian2 � Conflicts: � .travis.yml
ci error: |
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
==========================================
- Coverage 67.61% 67.56% -0.05%
==========================================
Files 25 26 +1
Lines 2671 2667 -4
==========================================
- Hits 1806 1802 -4
Misses 644 644
Partials 221 221
Continue to review full report at Codecov.
|
@zhangymPerson can u add another unit test , which check whether the uuid string generated by java is equal to that generated by golang ? |
@zhangymPerson maybe u do not got what I means, u response uuid string like the following and check whether it's equal to public static String javautilUUIDString() {
UUID uuid = new UUID(459021424248441700L, -7160773830801198154L);
return uuid.toString();
} |
* add license checker * dd javaProject java8time test code and add go hessian/java8_time strcut Year and testFunc * alter author and error word * add java.util.UUID encode * Revert "reset go.mod after go fmt" This reverts commit ab7254f * add UUID test * alter .travis.yml * alter code * add license * shift count type int, must be unsigned integer * alter file name and delete test file * alter file name * delete file * alter file name * alter file name * add uuid struct info and split import block. * add java UUID encode and uuid.toString() equals go uuid.ToString() test func * alter ToString() -> String() * fix code review Co-authored-by: zouyixian <zouyixian@shein.com> Co-authored-by: wilson chen <willson.chenwx@gmail.com> Co-authored-by: wangoo <wongoo@apache.org>
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: