Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map decode error issue #259 #261

Merged
merged 4 commits into from
Mar 13, 2021
Merged

Fix map decode error issue #259 #261

merged 4 commits into from
Mar 13, 2021

Conversation

wongoo
Copy link
Contributor

@wongoo wongoo commented Mar 11, 2021

What this PR does:
Fix map decode error issue

Which issue(s) this PR fixes:

Fixes #259

Special notes for your reviewer:
the map type should be added into type map, not the class def map. see http://hessian.caucho.com/doc/hessian-serialization.html##type-map

Does this PR introduce a user-facing change?:

- Fix map decode error issue #259 

@wongoo wongoo requested review from AlexStocks, fangyincheng, gaoxinge and zouyx and removed request for AlexStocks and fangyincheng March 11, 2021 14:18
object.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #261 (9696ab9) into master (db6d4e2) will decrease coverage by 0.45%.
The diff coverage is 51.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
- Coverage   67.41%   66.96%   -0.46%     
==========================================
  Files          25       25              
  Lines        2655     2658       +3     
==========================================
- Hits         1790     1780      -10     
- Misses        644      657      +13     
  Partials      221      221              
Impacted Files Coverage Δ
map.go 52.77% <42.30%> (-2.10%) ⬇️
decode.go 69.09% <60.86%> (-2.91%) ⬇️
pojo.go 59.65% <0.00%> (-5.69%) ⬇️
double.go 87.14% <0.00%> (+1.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db6d4e2...ece0e49. Read the comment docs.

@AlexStocks AlexStocks merged commit f61ce42 into apache:master Mar 13, 2021
zhaoyunxing92 pushed a commit that referenced this pull request Sep 4, 2021
Fix map decode error issue #259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map里面的decimal类型无法解析
5 participants