Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix duplicatedly adding list type in type map #263

Merged
merged 3 commits into from
Mar 17, 2021
Merged

fix duplicatedly adding list type in type map #263

merged 3 commits into from
Mar 17, 2021

Conversation

wongoo
Copy link
Contributor

@wongoo wongoo commented Mar 16, 2021

What this PR does:

  • fix duplicatedly adding list type in type map

Which issue(s) this PR fixes:
None

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- fix duplicatedly adding list type in type map

@wongoo
Copy link
Contributor Author

wongoo commented Mar 16, 2021

the test fail for go1.13 there is infinite loop to call reflect.deepequal , which is ok for go1.16

@wenxuwan
Copy link
Member

the test fail for go1.13 there is infinite loop to call reflect.deepequal , which is ok for go1.16

I am using version 1.13 in my environment now. Will this error have any effect?

@wongoo
Copy link
Contributor Author

wongoo commented Mar 16, 2021

the test fail for go1.13 there is infinite loop to call reflect.deepequal , which is ok for go1.16

I am using version 1.13 in my environment now. Will this error have any effect?

Hessian supports object loop reference， it's not the issue of hessian.
There is infinite loop only when calling reflect.deepequal to check self reference object.

Anyway, I'll change the unit test to not use the reflect.deepequal.

@wenxuwan
Copy link
Member

the test fail for go1.13 there is infinite loop to call reflect.deepequal , which is ok for go1.16

I am using version 1.13 in my environment now. Will this error have any effect?

Hessian supports object loop reference， it's not the issue of hessian.
There is infinite loop only when calling reflect.deepequal to check self reference object.

Anyway, I'll change the unit test to not use the reflect.deepequal.

got it , thanks for your response

@AlexStocks
Copy link
Contributor

pls fix the ut failure.

zouyx
zouyx reviewed Mar 17, 2021
View reviewed changes
Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one of checking was fail....

@wongoo
Copy link
Contributor Author

wongoo commented Mar 17, 2021

unit test already been fixed， I will merge this pr

@wongoo wongoo merged commit bdf7603 into apache:master Mar 17, 2021
zhaoyunxing92 pushed a commit that referenced this pull request Sep 4, 2021
@wongoo
fix duplicatedly adding list type in type map (#263)
6d0dc1c 
* fix duplicatedly adding list type in type map

* add unit test for map/list self ref

* using assert.Equal to check ref object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zouyx zouyx zouyx approved these changes

@LaurenceLiZhixin LaurenceLiZhixin LaurenceLiZhixin approved these changes

@gaoxinge gaoxinge gaoxinge approved these changes

@wenxuwan wenxuwan wenxuwan approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

@fangyincheng fangyincheng Awaiting requested review from fangyincheng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wongoo @wenxuwan @AlexStocks @zouyx @gaoxinge @LaurenceLiZhixin